Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757195Ab3GRIYg (ORCPT ); Thu, 18 Jul 2013 04:24:36 -0400 Received: from service87.mimecast.com ([91.220.42.44]:53438 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756898Ab3GRIYc convert rfc822-to-8bit (ORCPT ); Thu, 18 Jul 2013 04:24:32 -0400 Message-ID: <51E7A63F.7020207@arm.com> Date: Thu, 18 Jul 2013 09:24:31 +0100 From: Sudeep KarkadaNagesha User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Lunn CC: Sudeep KarkadaNagesha , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , Russell King , Shawn Guo , Gregory Clement , Greg Kroah-Hartman , Viresh Kumar , "Rafael J. Wysocki" , "grant.likely@linaro.org" , "rob.herring@calxeda.com" , Lorenzo Pieralisi , Olof Johansson , Arnd Bergmann , Jason Cooper Subject: Re: [RFC PATCH v2 11/15] cpufreq: kirkwood-cpufreq: remove device tree parsing for cpu nodes References: <1374069984-20567-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1374069984-20567-12-git-send-email-Sudeep.KarkadaNagesha@arm.com> <20130717144355.GE1026@lunn.ch> In-Reply-To: <20130717144355.GE1026@lunn.ch> X-OriginalArrivalTime: 18 Jul 2013 08:24:25.0510 (UTC) FILETIME=[369CD460:01CE8390] X-MC-Unique: 113071809243001601 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2621 Lines: 78 On 17/07/13 15:43, Andrew Lunn wrote: > On Wed, Jul 17, 2013 at 03:06:20PM +0100, Sudeep.KarkadaNagesha@arm.com wrote: >> From: Sudeep KarkadaNagesha >> >> Now that the cpu device registration initialises the of_node(if available) >> appropriately for all the cpus, parsing here is redundant. >> >> This patch removes all DT parsing and uses cpu->of_node instead. >> >> Cc: Andrew Lunn >> Cc: Jason Cooper >> Acked-by: Viresh Kumar >> Signed-off-by: Sudeep KarkadaNagesha >> --- >> drivers/cpufreq/kirkwood-cpufreq.c | 14 ++++++++++++-- >> 1 file changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c >> index c233ea6..18aa3eb 100644 >> --- a/drivers/cpufreq/kirkwood-cpufreq.c >> +++ b/drivers/cpufreq/kirkwood-cpufreq.c >> @@ -13,6 +13,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -165,6 +166,7 @@ static struct cpufreq_driver kirkwood_cpufreq_driver = { >> static int kirkwood_cpufreq_probe(struct platform_device *pdev) >> { >> struct device_node *np; >> + struct device *cpu_dev; >> struct resource *res; >> int err; >> >> @@ -175,9 +177,17 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) >> if (IS_ERR(priv.base)) >> return PTR_ERR(priv.base); >> >> - np = of_find_node_by_path("/cpus/cpu@0"); >> - if (!np) >> + cpu_dev = get_cpu_device(0); >> + if (!cpu_dev) { >> + dev_err(&pdev->dev, "failed to get cpu device\n"); >> return -ENODEV; >> + } >> + >> + np = of_node_get(cpu_dev->of_node); >> + if (!np) { >> + dev_err(&pdev->dev, "failed to get cpu device node\n"); >> + return -ENODEV; >> + } > > Hi Sudeep > > Are we not going a bit backwards here? You are replacing two lines > with 10 lines. > > How about putting these 10 lines into some helper, > of_get_cpu_device()? It would be useful for spear, kirkwood and > imx6q, and maybe others. > Yes I realised that after making changes to this and pmac32 drivers. I have already made those changes in v3. I am waiting for more response before posting them. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/