Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759197Ab3GRQTX (ORCPT ); Thu, 18 Jul 2013 12:19:23 -0400 Received: from merlin.infradead.org ([205.233.59.134]:37002 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758379Ab3GRQTW (ORCPT ); Thu, 18 Jul 2013 12:19:22 -0400 Date: Thu, 18 Jul 2013 13:19:13 -0300 From: Arnaldo Carvalho de Melo To: Robert Richter Cc: Borislav Petkov , Ingo Molnar , hpa@zytor.com, linux-kernel@vger.kernel.org, jolsa@redhat.com, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Subject: Re: [PATCH] perf tools: Fix 'make tools/perf' Message-ID: <20130718161913.GA2288@ghostprotocols.net> References: <1370964158-4135-1-git-send-email-rric@kernel.org> <20130712093909.GD8731@rric.localhost> <20130716145036.GH8731@rric.localhost> <20130717153118.GC2071@ghostprotocols.net> <20130717154001.GA4454@pd.tnic> <20130717161051.GJ8731@rric.localhost> <20130718121924.GL8731@rric.localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130718121924.GL8731@rric.localhost> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by merlin.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1967 Lines: 55 Em Thu, Jul 18, 2013 at 02:19:24PM +0200, Robert Richter escreveu: > Arnaldo, > > I noticed you applied the patch to acme/perf/core, but it should be > instead in urgent since mainline is broken. I did it because there are alternative ways to build the tools that don't require this fix, i.e. this is not _strictly_ needed to build the tools. What do you guys think: a case like this always needs to go to the current release candidate? Ingo? - Arnaldo > On 17.07.13 18:10:51, Robert Richter wrote: > > On 17.07.13 17:40:01, Borislav Petkov wrote: > > > On Wed, Jul 17, 2013 at 12:31:18PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Humm, probably it will look at the top level 'install' target? There > > > > was some discussion about this, right? Can you refresh my mind? > > Now tested with: > > make O=... DESTDIR=... tools/perf > make O=... DESTDIR=... tools/perf_install > make O=... DESTDIR=... -C tools/ perf > make O=... DESTDIR=... -C tools/ perf_install > make O=... DESTDIR=... -C tools/perf > make O=... DESTDIR=... -C tools/perf install > make tools/perf > make DESTDIR=... tools/perf_install > make -C tools/ perf > make -C tools/ DESTDIR=... perf_install > make -C tools/perf > make -C tools/perf DESTDIR=... install > > No issues noticed, accept that doc is built when running the 'install' > target, not 'all'. > > Will look at this. > > We also should remove dependencies from install targets that trigger a > rebuild since 'make install' is run as root. I had a conversation with > Linus about this for building the arm kernel, but the same applies > also for perf tools. I don't have the time for changing this now, but > maybe in some weeks or so. > > Thanks, > > -Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/