Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934553Ab3GRXRP (ORCPT ); Thu, 18 Jul 2013 19:17:15 -0400 Received: from mail-ve0-f178.google.com ([209.85.128.178]:56334 "EHLO mail-ve0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932828Ab3GRXRO (ORCPT ); Thu, 18 Jul 2013 19:17:14 -0400 MIME-Version: 1.0 In-Reply-To: <20130718230312.GA22348@www.outflux.net> References: <20130718230312.GA22348@www.outflux.net> Date: Thu, 18 Jul 2013 16:17:12 -0700 Message-ID: Subject: Re: [PATCH] panic: call panic handlers before kmsg_dump From: Tony Luck To: Kees Cook Cc: Linux Kernel Mailing List , Andrew Morton , Anton Vorontsov , Colin Cross , Stephen Boyd , Vikram Mulukutla , Peter Zijlstra , Rusty Russell Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 752 Lines: 16 On Thu, Jul 18, 2013 at 4:03 PM, Kees Cook wrote: > Since the panic handlers may produce additional information (via printk) > for the kernel log, it should be reported as part of the panic output > saved by kmsg_dump(). Without this re-ordering, nothing that adds > information to a panic will show up in pstore's view when kmsg_dump > runs, and is therefore not visible to crash reporting tools that examine > pstore output. Good point. Acked-by: Tony Luck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/