Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759569Ab3GSBwC (ORCPT ); Thu, 18 Jul 2013 21:52:02 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:16671 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753153Ab3GSBwA (ORCPT ); Thu, 18 Jul 2013 21:52:00 -0400 X-Authority-Analysis: v=2.0 cv=e9yEuNV/ c=1 sm=0 a=Sro2XwOs0tJUSHxCKfOySw==:17 a=Drc5e87SC40A:10 a=GZfv41eBbK4A:10 a=5SG0PmZfjMsA:10 a=IkcTkHD0fZMA:10 a=meVymXHHAAAA:8 a=KGjhK52YXX0A:10 a=WXzlLm9s7TAA:10 a=Zweq5UuF66qIPCqdNBgA:9 a=QEXdDO2ut3YA:10 a=Sro2XwOs0tJUSHxCKfOySw==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 67.255.60.225 Message-ID: <1374198719.3356.9.camel@gandalf.local.home> Subject: Re: [PATCH 2/3] tracing: use trace_seq_puts()/trace_seq_putc() where possible From: Steven Rostedt To: "zhangwei(Jovi)" Cc: Frederic Weisbecker , Ingo Molnar , "linux-kernel@vger.kernel.org" Date: Thu, 18 Jul 2013 21:51:59 -0400 In-Reply-To: <51E898FB.2000006@huawei.com> References: <51E3B3AC.1000605@huawei.com> <1374197370.3356.8.camel@gandalf.local.home> <51E898FB.2000006@huawei.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 42 On Fri, 2013-07-19 at 09:40 +0800, zhangwei(Jovi) wrote: > On 2013/7/19 9:29, Steven Rostedt wrote: > > On Mon, 2013-07-15 at 16:32 +0800, zhangwei(Jovi) wrote: > >> diff --git a/kernel/trace/trace_functions_graph.c > >> b/kernel/trace/trace_functions_graph.c > >> index 8388bc9..3793f90 100644 > >> --- a/kernel/trace/trace_functions_graph.c > >> +++ b/kernel/trace/trace_functions_graph.c > >> @@ -446,7 +446,7 @@ print_graph_proc(struct trace_seq *s, pid_t pid) > >> > >> /* First spaces to align center */ > >> for (i = 0; i < spaces / 2; i++) { > >> - ret = trace_seq_printf(s, " "); > >> + ret = trace_seq_putc(s, ' '); > >> if (!ret) > >> return TRACE_TYPE_PARTIAL_LINE; > >> } > >> @@ -457,7 +457,7 @@ print_graph_proc(struct trace_seq *s, pid_t pid) > >> > >> /* Last spaces to align center */ > >> for (i = 0; i < spaces - (spaces / 2); i++) { > >> - ret = trace_seq_printf(s, " "); > >> + ret = trace_seq_putc(s, " "); > > > > Oops, s/"/'/g > > > > I'll fix it. > > > Sorry for this, I will open my eyes more larger next time. > Honest mistake. My tests caught it, as ktest will fail a test if a patch causes a new warning to appear. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/