Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935133Ab3GSCdn (ORCPT ); Thu, 18 Jul 2013 22:33:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37728 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759441Ab3GSCXn (ORCPT ); Thu, 18 Jul 2013 22:23:43 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yu Liu , Shane Huang , Tejun Heo Subject: [ 13/18] ahci: remove pmp link online check in FBS EH Date: Thu, 18 Jul 2013 19:23:28 -0700 Message-Id: <20130719021049.870089104@linuxfoundation.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <20130719021048.965829361@linuxfoundation.org> References: <20130719021048.965829361@linuxfoundation.org> User-Agent: quilt/0.60-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 40 3.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shane Huang commit 912b9ac683b112615d5605686f1dc086402ce9f7 upstream. ata_link_online() check in ahci_error_intr() is unnecessary, it should be removed otherwise may lead to lockup with FBS enabled PMP. http://marc.info/?l=linux-ide&m=137050421603272&w=2 Reported-by: Yu Liu Signed-off-by: Shane Huang Signed-off-by: Tejun Heo Signed-off-by: Greg Kroah-Hartman --- drivers/ata/libahci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -1495,8 +1495,7 @@ static void ahci_error_intr(struct ata_p u32 fbs = readl(port_mmio + PORT_FBS); int pmp = fbs >> PORT_FBS_DWE_OFFSET; - if ((fbs & PORT_FBS_SDE) && (pmp < ap->nr_pmp_links) && - ata_link_online(&ap->pmp_link[pmp])) { + if ((fbs & PORT_FBS_SDE) && (pmp < ap->nr_pmp_links)) { link = &ap->pmp_link[pmp]; fbs_need_dec = true; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/