Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965753Ab3GSH74 (ORCPT ); Fri, 19 Jul 2013 03:59:56 -0400 Received: from mail-ea0-f175.google.com ([209.85.215.175]:48040 "EHLO mail-ea0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965421Ab3GSH7v (ORCPT ); Fri, 19 Jul 2013 03:59:51 -0400 Date: Fri, 19 Jul 2013 09:59:47 +0200 From: Ingo Molnar To: "Ren, Qiaowei" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "Wei, Gang" Subject: Re: [PATCH v3] x86, tboot: iomem fixes Message-ID: <20130719075947.GC22597@gmail.com> References: <1374134874-8161-1-git-send-email-qiaowei.ren@intel.com> <20130718104223.GD23558@gmail.com> <9E0BE1322F2F2246BD820DA9FC397ADE013C8C77@SHSMSX102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9E0BE1322F2F2246BD820DA9FC397ADE013C8C77@SHSMSX102.ccr.corp.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3267 Lines: 87 * Ren, Qiaowei wrote: > On 2013-07-18, Ingo Molnar wrote: > > > > * Qiaowei Ren wrote: > > > >> Current code doesn't use specific interface to access I/O space. > >> So some potential bugs can be caused. We can fix this by using > >> specific API. > > > > This is still very vague. > > > >> > >> Signed-off-by: Qiaowei Ren > >> --- > >> arch/x86/kernel/tboot.c | 21 ++++++++++++--------- > >> 1 file changed, 12 insertions(+), 9 deletions(-) > >> diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c index > >> 3ff42d2..afe8cf8 100644 > >> --- a/arch/x86/kernel/tboot.c > >> +++ b/arch/x86/kernel/tboot.c > >> @@ -466,9 +466,12 @@ struct sinit_mle_data { > >> u32 vtd_dmars_off; > >> } __packed; > >> +#define SINIT_MLE_DATA_VTD_DMAR_OFF 140 > >> + > >> struct acpi_table_header *tboot_get_dmar_table(struct > >> acpi_table_header *dmar_tbl) { > >> - void *heap_base, *heap_ptr, *config; > >> + void __iomem *heap_base, *heap_ptr, *config; > >> + u32 dmar_tbl_off; > >> > >> if (!tboot_enabled()) > >> return dmar_tbl; > >> @@ -485,25 +488,25 @@ struct acpi_table_header > > *tboot_get_dmar_table(struct acpi_table_header *dmar_tb > >> return NULL; > >> > >> /* now map TXT heap */ > >> - heap_base = ioremap(*(u64 *)(config + TXTCR_HEAP_BASE), > >> - *(u64 *)(config + TXTCR_HEAP_SIZE)); > >> + heap_base = ioremap(readl(config + TXTCR_HEAP_BASE), > >> + readl(config + TXTCR_HEAP_SIZE)); > >> iounmap(config); > >> if (!heap_base) > >> return NULL; > >> > >> /* walk heap to SinitMleData */ > >> /* skip BiosData */ > >> - heap_ptr = heap_base + *(u64 *)heap_base; > >> + heap_ptr = heap_base + readq(heap_base); > >> /* skip OsMleData */ > >> - heap_ptr += *(u64 *)heap_ptr; > >> + heap_ptr += readq(heap_ptr); > >> /* skip OsSinitData */ > >> - heap_ptr += *(u64 *)heap_ptr; > >> + heap_ptr += readq(heap_ptr); > >> /* now points to SinitMleDataSize; set to SinitMleData */ > >> heap_ptr += sizeof(u64); > >> /* get addr of DMAR table */ > >> - dmar_tbl = (struct acpi_table_header *)(heap_ptr + > >> - ((struct sinit_mle_data *)heap_ptr)->vtd_dmars_off - > >> - sizeof(u64)); > >> + dmar_tbl_off = readl(heap_ptr + SINIT_MLE_DATA_VTD_DMAR_OFF); > >> + memcpy_fromio(dmar_tbl, heap_ptr + dmar_tbl_off - sizeof(u64), > >> + sizeof(struct acpi_table_header)); > > > > That memcpy (or an equivalent of it) was not in the code before, AFAICS. > > > > How can this be an 'interface fix'? It adds in new code... > > > Sorry, current code only need to get addr of DMAR table, so memcpy_fromio may be removed, even though this will also work. > So "memcpy_fromio" line will be changed to > dmar_tbl = (struct acpi_table_header *)(heap_ptr + dmar_tbl_off + - sizeof(u64)); > If so, no new interface will be added, and the changelog at the beginning of this patch is engouch? Please resubmit the fixed patch so I can have a fresh look. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/