Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760022Ab3GSJBL (ORCPT ); Fri, 19 Jul 2013 05:01:11 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:50994 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241Ab3GSJBH (ORCPT ); Fri, 19 Jul 2013 05:01:07 -0400 Message-ID: <51E8FF76.5030706@linux.vnet.ibm.com> Date: Fri, 19 Jul 2013 14:27:26 +0530 From: "Srivatsa S. Bhat" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Lai Jiangshan CC: "linux-kernel@vger.kernel.org" , Tejun Heo , "Rafael J. Wysocki" , bhelgaas@google.com Subject: Re: workqueue, pci: INFO: possible recursive locking detected References: <51E55B7D.2040209@linux.vnet.ibm.com> <51E66CCC.9010600@cn.fujitsu.com> <51E84EDC.5090502@linux.vnet.ibm.com> <51E89ABB.20808@cn.fujitsu.com> In-Reply-To: <51E89ABB.20808@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13071908-5140-0000-0000-0000038BAF82 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5475 Lines: 145 On 07/19/2013 07:17 AM, Lai Jiangshan wrote: > On 07/19/2013 04:23 AM, Srivatsa S. Bhat wrote: >> >> --- >> >> kernel/workqueue.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> >> diff --git a/kernel/workqueue.c b/kernel/workqueue.c >> index f02c4a4..07d9a67 100644 >> --- a/kernel/workqueue.c >> +++ b/kernel/workqueue.c >> @@ -4754,7 +4754,13 @@ long work_on_cpu(int cpu, long (*fn)(void *), void *arg) >> { >> struct work_for_cpu wfc = { .fn = fn, .arg = arg }; >> >> +#ifdef CONFIG_LOCKDEP >> + static struct lock_class_key __key; > > Sorry, this "static" should be removed. > That didn't help either :-( Because it makes lockdep unhappy, since the key isn't persistent. This is the patch I used: --- diff --git a/kernel/workqueue.c b/kernel/workqueue.c index f02c4a4..7967e3b 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -4754,7 +4754,13 @@ long work_on_cpu(int cpu, long (*fn)(void *), void *arg) { struct work_for_cpu wfc = { .fn = fn, .arg = arg }; +#ifdef CONFIG_LOCKDEP + struct lock_class_key __key; + INIT_WORK_ONSTACK(&wfc.work, work_for_cpu_fn); + lockdep_init_map(&wfc.work.lockdep_map, "&wfc.work", &__key, 0); +#else INIT_WORK_ONSTACK(&wfc.work, work_for_cpu_fn); +#endif schedule_work_on(cpu, &wfc.work); flush_work(&wfc.work); return wfc.ret; And here are the new warnings: Block layer SCSI generic (bsg) driver version 0.4 loaded (major 252) io scheduler noop registered io scheduler deadline registered io scheduler cfq registered (default) BUG: key ffff881039557b98 not in .data! ------------[ cut here ]------------ WARNING: CPU: 8 PID: 1 at kernel/lockdep.c:2987 lockdep_init_map+0x168/0x170() DEBUG_LOCKS_WARN_ON(1) Modules linked in: CPU: 8 PID: 1 Comm: swapper/0 Not tainted 3.11.0-rc1-wq-fix3-a #12 Hardware name: IBM -[8737R2A]-/00Y2738, BIOS -[B2E120RUS-1.20]- 11/30/2012 0000000000000bab ffff881039557a58 ffffffff81619069 ffffffff819f6dce ffff881039557aa8 ffff881039557a98 ffffffff8104e6ac ffff881039557b98 ffff881039557b58 0000000000000000 ffff881039557b58 0000000000000000 Call Trace: [] dump_stack+0x59/0x80 [] warn_slowpath_common+0x8c/0xc0 [] warn_slowpath_fmt+0x46/0x50 [] lockdep_init_map+0x168/0x170 [] work_on_cpu+0x96/0xd0 [] ? wqattrs_hash+0x190/0x190 [] ? pci_pm_prepare+0x60/0x60 [] __pci_device_probe+0x9a/0xe0 [] ? _raw_spin_unlock_irq+0x30/0x50 [] ? pci_dev_get+0x22/0x30 [] pci_device_probe+0x3a/0x60 [] ? _raw_spin_unlock_irq+0x30/0x50 [] really_probe+0x6c/0x320 [] driver_probe_device+0x47/0xa0 [] __driver_attach+0xab/0xb0 [] ? driver_probe_device+0xa0/0xa0 [] ? driver_probe_device+0xa0/0xa0 [] bus_for_each_dev+0x94/0xb0 [] driver_attach+0x1e/0x20 [] bus_add_driver+0x208/0x290 [] driver_register+0x77/0x160 [] ? dmi_pcie_pme_disable_msi+0x21/0x21 [] __pci_register_driver+0x64/0x70 [] pcie_portdrv_init+0x69/0x7a [] do_one_initcall+0xf2/0x1a0 [] ? parse_args+0x156/0x2f0 [] ? kernel_init_freeable+0x28a/0x28a [] do_basic_setup+0x9d/0xbb [] ? kernel_init_freeable+0x28a/0x28a [] kernel_init_freeable+0x20a/0x28a [] ? rest_init+0x180/0x180 [] kernel_init+0xe/0xf0 [] ret_from_fork+0x7c/0xb0 [] ? rest_init+0x180/0x180 ---[ end trace 41047d25544a3721 ]--- pcieport 0000:00:01.0: irq 88 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:00:02.0: irq 89 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:00:02.2: irq 90 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:00:03.0: irq 91 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:00:11.0: irq 92 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:00:1c.0: irq 93 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:00:1c.4: irq 94 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! BUG: key ffff881039557b98 not in .data! BUG: key ffff881039557b98 not in .data! BUG: key ffff881039557b98 not in .data! BUG: key ffff881039557b98 not in .data! pcieport 0000:80:00.0: irq 95 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:80:01.0: irq 96 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:80:01.1: irq 97 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:80:02.0: irq 98 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:80:02.2: irq 99 for MSI/MSI-X BUG: key ffff881039557b98 not in .data! pcieport 0000:80:03.0: irq 100 for MSI/MSI-X pcieport 0000:00:01.0: Signaling PME through PCIe PME interrupt pcie_pme 0000:00:01.0:pcie01: service driver pcie_pme loaded Regards, Srivatsa S. Bhat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/