Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760088Ab3GSMGB (ORCPT ); Fri, 19 Jul 2013 08:06:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57386 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111Ab3GSMF7 (ORCPT ); Fri, 19 Jul 2013 08:05:59 -0400 Date: Fri, 19 Jul 2013 14:08:43 +0200 From: Stanislaw Gruszka To: Ortwin =?iso-8859-1?Q?Gl=FCck?= Cc: Arend van Spriel , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [BUG] 3.10 regression: hang on suspend Message-ID: <20130719120842.GA1570@redhat.com> References: <51E4501D.3010001@odi.ch> <20130716065626.GA1587@redhat.com> <51E4F790.6090308@odi.ch> <51E51712.4020609@broadcom.com> <51E58FA5.4000804@odi.ch> <20130717122944.GA25894@redhat.com> <51E6E1AB.5010300@odi.ch> <20130718105550.GA4628@redhat.com> <51E83AB7.6020002@odi.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <51E83AB7.6020002@odi.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 32 On Thu, Jul 18, 2013 at 08:57:59PM +0200, Ortwin Gl?ck wrote: > On 07/18/2013 12:55 PM, Stanislaw Gruszka wrote: > >objdump -r -d --prefix-addresses net/mac80211/mac80211.ko > mac80211.txt > >objdump -r -d --prefix-addresses drivers/net/wireless/iwlwifi/dvm/iwldvm.ko > iwldvm.txt > > Here you go. Please note, that the offsets have changed due to > .config changes. New trace attached. Transcript: > > iwlagn_mac_remove_interface+0x5f/0x160 > __ieee80211_suspend+0x4a1/0xb30 > ieee80211_suspend+0x1a/0x20 Crash happen because we call iwlagn_mac_remove_interface with vif_priv->ctx NULL. I do not see any possibility of that other than doing ->remove_interface without previous ->add_interface, but I do not see how that possible. Does crash happen on any suspend or on second one ? I'm attaching patch, which should prevent crash (but not fix the issue, just workaround it), plese apply it. If it make suspend work, please then reload iwlwifi module with debug=0x3 option, suspend/resume machine and provide dmesg output after that. Thanks Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/