Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760345Ab3GSMIw (ORCPT ); Fri, 19 Jul 2013 08:08:52 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:51974 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760285Ab3GSMIs (ORCPT ); Fri, 19 Jul 2013 08:08:48 -0400 From: "Rafael J. Wysocki" To: Robert Hancock Cc: Mika Westerberg , Greg Kroah-Hartman , Bjorn Helgaas , "Rafael J. Wysocki" , Jesse Barnes , Yinghai Lu , john.ronciak@intel.com, miles.j.penner@intel.com, bruce.w.allan@intel.com, Heikki Krogerus , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 6/8] PCI: acpiphp: workaround for Thunderbolt on Acer Aspire S5 Date: Fri, 19 Jul 2013 14:18:41 +0200 Message-ID: <5137167.kOnaWbA4s1@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <51E8B923.5090201@gmail.com> References: <1372860295-8306-1-git-send-email-mika.westerberg@linux.intel.com> <1444243.g9GbxN3NM0@vostro.rjw.lan> <51E8B923.5090201@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2987 Lines: 83 On Thursday, July 18, 2013 09:57:23 PM Robert Hancock wrote: > On 07/03/2013 03:40 PM, Rafael J. Wysocki wrote: > > On Wednesday, July 03, 2013 05:04:53 PM Mika Westerberg wrote: > >> From: "Kirill A. Shutemov" > >> > >> Correct ACPI PCI hotplug imeplementation should have _RMV method in a > >> PCI slot (device under pci bridge). In Acer Aspire S5 case we have it > >> deeper in hierarchy: > >> > >> Device (RP05) > >> { > >> // ... > >> Device (HRUP) > >> { > >> // ... > >> Device (HRDN) > >> { > >> // ... > >> Device (EPUP) > >> { > >> // ... > >> Method (_RMV, 0, NotSerialized) // _RMV: Removal Status > >> { > >> Return (One) > >> } > >> } > >> } > >> } > >> } > >> > >> Signed-off-by: Kirill A. Shutemov > >> Signed-off-by: Mika Westerberg > >> --- > >> drivers/pci/hotplug/acpi_pcihp.c | 13 +++++++++++++ > >> 1 file changed, 13 insertions(+) > >> > >> diff --git a/drivers/pci/hotplug/acpi_pcihp.c b/drivers/pci/hotplug/acpi_pcihp.c > >> index 2a47e82..d92ebfb 100644 > >> --- a/drivers/pci/hotplug/acpi_pcihp.c > >> +++ b/drivers/pci/hotplug/acpi_pcihp.c > >> @@ -422,6 +422,19 @@ static int pcihp_is_ejectable(acpi_handle handle) > >> status = acpi_evaluate_integer(handle, "_RMV", NULL, &removable); > >> if (ACPI_SUCCESS(status) && removable) > >> return 1; > >> + > >> + /* > >> + * Workaround for Thunderbolt implementation on Acer Aspire S5. > >> + * > >> + * Correct ACPI PCI hotplug imeplementation has _RMV method in a PCI > >> + * slot (device under pci bridge). In Acer Aspire S5 case we have it > >> + * deeper in hierarchy. > >> + */ > >> + status = acpi_evaluate_integer(handle, "HRDN.EPUP._RMV", NULL, > >> + &removable); > > > > Well, calling stuff like this directly from a general function is kind of ugly. > > > > Can we use something like a quirk instead? A DMI check or something? > > Presumably this device functions under Windows so clearly Windows is > capable of dealing with this case, so we should too. > > There are way too many of these silly DMI checks in the kernel - we > should be way more hesitant to add more of them. They're almost > guaranteed to be incomplete. I would say they should be avoided whenever > possible unless there's some reason why a general workaround can't be used. This horse is already dead. :-) Please check the series I posted the day before yesterday. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/