Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760762Ab3GSOUl (ORCPT ); Fri, 19 Jul 2013 10:20:41 -0400 Received: from www.linutronix.de ([62.245.132.108]:50022 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754828Ab3GSOUf (ORCPT ); Fri, 19 Jul 2013 10:20:35 -0400 Message-ID: <51E94B30.9070805@linutronix.de> Date: Fri, 19 Jul 2013 16:20:32 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 MIME-Version: 1.0 To: Sergei Shtylyov CC: George Cherian , linux-usb@vger.kernel.org, balbi@ti.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, linux-omap@vger.kernel.org, kishon@ti.com Subject: Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX References: <1374237277-17769-1-git-send-email-george.cherian@ti.com> <1374237277-17769-4-git-send-email-george.cherian@ti.com> <51E94571.8080805@cogentembedded.com> In-Reply-To: <51E94571.8080805@cogentembedded.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1990 Lines: 68 On 07/19/2013 03:56 PM, Sergei Shtylyov wrote: > On 19-07-2013 16:34, George Cherian wrote: > >> diff --git a/arch/arm/boot/dts/am33xx.dtsi >> b/arch/arm/boot/dts/am33xx.dtsi >> index 8e1248f..e3890c4 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi >> @@ -326,21 +326,59 @@ >> status = "disabled"; >> }; >> >> - usb@47400000 { >> - compatible = "ti,musb-am33xx"; >> - reg = <0x47400000 0x1000 /* usbss */ >> - 0x47401000 0x800 /* musb instance 0 */ >> - 0x47401800 0x800>; /* musb instance 1 */ >> - interrupts = <17 /* usbss */ >> - 18 /* musb instance 0 */ >> - 19>; /* musb instance 1 */ >> - multipoint = <1>; >> - num-eps = <16>; >> - ram-bits = <12>; >> - port0-mode = <3>; >> - port1-mode = <3>; >> - power = <250>; >> - ti,hwmods = "usb_otg_hs"; >> + phy1: am335x-usb0@44e10620 { > > Shouldn't the PHYs be *under* the usb0/1 device nodes in the hierarchy? > They're not on the same bus as the MUSB controllers for sure. I redo the complete thing. I have now: usb: usb@47400000 { compatible = "ti,am33xx-usb"; usb0_phy: phy@47401300 { compatible = "ti,am335x-usb-phy"; } usb0: usb@47401000 { musb0: usb@47401400 { compatible = "mg,musbmhdrc"; } } usb1_phy: phy@47402300 { compatible = "ti,am335x-usb-phy"; } usb1: usb@47402000 { musb1: usb@47402400 { compatible = "mg,musbmhdrc"; } } } And you want usb0_phy to be child of usb0? In the TRM they are all in the same block. > > WBR, Sergei > Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/