Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759000Ab3GSPIS (ORCPT ); Fri, 19 Jul 2013 11:08:18 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:54938 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490Ab3GSPIR (ORCPT ); Fri, 19 Jul 2013 11:08:17 -0400 MIME-Version: 1.0 In-Reply-To: <1374245148-24031-1-git-send-email-alexj@rosedu.org> References: <1374245148-24031-1-git-send-email-alexj@rosedu.org> Date: Fri, 19 Jul 2013 18:08:15 +0300 X-Google-Sender-Auth: SmnyfItwd1i1sT2HYoF1I-si67s Message-ID: Subject: Re: [PATCH] lustre:libcfs: remove redundant code. From: Pekka Enberg To: Alexandru Juncu Cc: Greg Kroah-Hartman , andreas.dilger@intel.com, tao.peng@emc.com, driverdev , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1583 Lines: 40 On Fri, Jul 19, 2013 at 5:45 PM, Alexandru Juncu wrote: > Found using coccinelle. It suggested kmalloc/strcpy should be replaced > with kstrdup, but the entire function can be replaced by kstrdup. > > Signed-off-by: Alexandru Juncu > --- > drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c > index 9edccc9..4dba304 100644 > --- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c > +++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c > @@ -135,18 +135,7 @@ EXPORT_SYMBOL(cfs_str2mask); > /* Duplicate a string in a platform-independent way */ > char *cfs_strdup(const char *str, u_int32_t flags) > { > - size_t lenz; /* length of str + zero byte */ > - char *dup_str; > - > - lenz = strlen(str) + 1; > - > - dup_str = kmalloc(lenz, flags); > - if (dup_str == NULL) > - return NULL; > - > - memcpy(dup_str, str, lenz); > - > - return dup_str; > + return kstrdup(str, flags); > } > EXPORT_SYMBOL(cfs_strdup); It would be better if you replaced the calls to cfs_strdup() with kstrdup() and got rid of cfs_strdup() altogether. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/