Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760825Ab3GSPm3 (ORCPT ); Fri, 19 Jul 2013 11:42:29 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:39476 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733Ab3GSPm2 (ORCPT ); Fri, 19 Jul 2013 11:42:28 -0400 Message-ID: <51E95DEB.7010702@ti.com> Date: Fri, 19 Jul 2013 18:40:27 +0300 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sergei Shtylyov CC: Oleksandr Kozaruk , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 1/2] ARM: dts: twl: Add GPADC data to device tree References: <1374226039-16943-1-git-send-email-oleksandr.kozaruk@ti.com> <1374226039-16943-2-git-send-email-oleksandr.kozaruk@ti.com> <51E94F97.40002@cogentembedded.com> In-Reply-To: <51E94F97.40002@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1520 Lines: 49 On 07/19/2013 05:39 PM, Sergei Shtylyov wrote: > Hello. > > On 19-07-2013 13:27, Oleksandr Kozaruk wrote: > >> GPADC is the general purpose ADC present on twl6030. >> The dt data is interrupt used to trigger end of ADC >> conversion. > >> Signed-off-by: Oleksandr Kozaruk >> --- >> arch/arm/boot/dts/twl6030.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) > >> diff --git a/arch/arm/boot/dts/twl6030.dtsi >> b/arch/arm/boot/dts/twl6030.dtsi >> index 2e3bd31..d7d4c28 100644 >> --- a/arch/arm/boot/dts/twl6030.dtsi >> +++ b/arch/arm/boot/dts/twl6030.dtsi >> @@ -103,4 +103,10 @@ >> compatible = "ti,twl6030-pwmled"; >> #pwm-cells = <2>; >> }; >> + >> + adc: gpadc { > > Read my lips: the node should be called just "adc", not "gpadc". ^^^^^^^^^^^^ Are you sure? Why? The name was selected according to the documentation on device "General purpose analog-to-digital converter (GPADC)". PS. Following your logic - "GPIO" need to renamed to "IO" everywhere ;P > > WBR, Sergei > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Regards, - grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/