Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760837Ab3GSPpb (ORCPT ); Fri, 19 Jul 2013 11:45:31 -0400 Received: from mail1.bemta7.messagelabs.com ([216.82.254.100]:59832 "EHLO mail1.bemta7.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753477Ab3GSPp1 (ORCPT ); Fri, 19 Jul 2013 11:45:27 -0400 X-Env-Sender: Hector.Palacios@digi.com X-Msg-Ref: server-10.tower-201.messagelabs.com!1374248724!9776979!4 X-Originating-IP: [66.77.174.13] X-StarScan-Received: X-StarScan-Version: 6.9.9; banners=-,-,- X-VirusChecked: Checked Message-ID: <51E95EF1.4040503@digi.com> Date: Fri, 19 Jul 2013 17:44:49 +0200 From: Hector Palacios Organization: Digi International User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Marek Vasut CC: "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "alexandre.belloni@free-electrons.com" , "jic23@kernel.org" , "lars@metafoo.de" , "fabio.estevam@freescale.com" Subject: Re: [PATCH v2 3/5] iio: mxs-lradc: add scale attribute to channels References: <1374225208-28940-1-git-send-email-hector.palacios@digi.com> <1374225208-28940-4-git-send-email-hector.palacios@digi.com> <201307191630.17149.marex@denx.de> In-Reply-To: <201307191630.17149.marex@denx.de> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1359 Lines: 49 Dear Marek, On 07/19/2013 04:30 PM, Marek Vasut wrote: >> @@ -228,39 +230,12 @@ struct mxs_lradc { >> #define LRADC_RESOLUTION 12 >> #define LRADC_SINGLE_SAMPLE_MASK ((1 << LRADC_RESOLUTION) - 1) >> >> -/* >> - * Raw I/O operations >> - */ >> -static int mxs_lradc_read_raw(struct iio_dev *iio_dev, >> +static int mxs_lradc_read_single(struct iio_dev *iio_dev, >> const struct iio_chan_spec *chan, >> int *val, int *val2, long m) >> { >> struct mxs_lradc *lradc = iio_priv(iio_dev); >> int ret; >> - unsigned long mask; >> - >> - if (m != IIO_CHAN_INFO_RAW) >> - return -EINVAL; >> - >> - /* Check for invalid channel */ >> - if (chan->channel > LRADC_MAX_TOTAL_CHANS) >> - return -EINVAL; > > This was already resolved, so this patch won't apply I'm afraid. You mean the 'unsigned long mask', right? Yeah, I think I had resolved that one before submitting, but looks like I didn't. The other check is not resolved afaik. We agreed to remove it, but on a different patch. > Otherwise: > > Acked-by: Marek Vasut > > > Marek Vasut > Best regards, -- Hector Palacios -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/