Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760627Ab3GSQXP (ORCPT ); Fri, 19 Jul 2013 12:23:15 -0400 Received: from mail-qc0-f170.google.com ([209.85.216.170]:59949 "EHLO mail-qc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759422Ab3GSQXO (ORCPT ); Fri, 19 Jul 2013 12:23:14 -0400 MIME-Version: 1.0 In-Reply-To: <1374250046.15242.7.camel@x61.thuisdomein> References: <1374245148-24031-1-git-send-email-alexj@rosedu.org> <20130719154648.GA23116@kroah.com> <1374250046.15242.7.camel@x61.thuisdomein> From: Alexandru Juncu Date: Fri, 19 Jul 2013 19:22:53 +0300 X-Google-Sender-Auth: a3ZFeoX0KCrqocc0Jcs2cEGuadU Message-ID: Subject: Re: [PATCH] lustre:libcfs: remove redundant code. To: Paul Bolle Cc: Greg Kroah-Hartman , Pekka Enberg , "andreas.dilger" , "tao.peng" , driverdev , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 25 On 19 July 2013 19:07, Paul Bolle wrote: > On Fri, 2013-07-19 at 08:46 -0700, Greg Kroah-Hartman wrote: >> Doesn't matter, if there are no users, please just remove it. > > Is that, basically, your approach to staging cleanups? > > I ask because I noticed that "drivers/staging/lustre/lustre/ptlrpc/gss/" > is only built if CONFIG_PTLRPC_GSS is set. But the corresponding Kconfig > symbol is nowhere to be found. > > Or do you prefer that I poke the people involved in (this case in) > Lustre before suggesting a drastic cleanup like that? Thanks for the comments! The comment for that function is "Duplicate a string in a platform-independent way" so it might be because it's called by code that also run on non-Linux systems. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/