Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760814Ab3GSQ32 (ORCPT ); Fri, 19 Jul 2013 12:29:28 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:41532 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754828Ab3GSQ30 (ORCPT ); Fri, 19 Jul 2013 12:29:26 -0400 MIME-Version: 1.0 In-Reply-To: <20130719154648.GA23116@kroah.com> References: <1374245148-24031-1-git-send-email-alexj@rosedu.org> <20130719154648.GA23116@kroah.com> Date: Fri, 19 Jul 2013 19:29:25 +0300 Message-ID: Subject: Re: [PATCH] lustre:libcfs: remove redundant code. From: Daniel Baluta To: Greg Kroah-Hartman Cc: Alexandru Juncu , Pekka Enberg , "andreas.dilger" , "tao.peng" , driverdev , LKML , pebolle@tiscali.nl Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 28 On Fri, Jul 19, 2013 at 6:46 PM, Greg Kroah-Hartman wrote: > On Fri, Jul 19, 2013 at 06:29:34PM +0300, Alexandru Juncu wrote: >> On 19 July 2013 18:21, Pekka Enberg wrote: >> > On Fri, Jul 19, 2013 at 6:13 PM, Alexandru Juncu wrote: >> >> I was thinking the same thing, but I hesitated because I didn't know >> >> how used it was and I didn't want to break something. >> > >> > "git grep cfs_strdup" suggests that nobody uses it so you could just >> > remove it completely... >> >> Did a grep on the tree and yes, it's not used. But It's in a staging >> directory so maybe the rest of the code has not been pushed in yet. > > Doesn't matter, if there are no users, please just remove it. Hi Greg, There is already a similar patch for this https://lkml.org/lkml/2013/7/17/742, already reviewed by Andreas Dilger. thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/