Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932345Ab3GSSSx (ORCPT ); Fri, 19 Jul 2013 14:18:53 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:35290 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760631Ab3GSSSv (ORCPT ); Fri, 19 Jul 2013 14:18:51 -0400 Message-ID: <51E98310.7020103@cogentembedded.com> Date: Fri, 19 Jul 2013 22:18:56 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Grygorii Strashko CC: Oleksandr Kozaruk , tony@atomide.com, benoit.cousson@linaro.org, rnayak@ti.com, peter.ujfalusi@ti.com, kishon@ti.com, jic23@cam.ac.uk, grant.likely@linaro.org, rob.herring@calxeda.com, lars@metafoo.de, sameo@linux.intel.com, ch.naveen@samsung.com, poeschel@lemonage.de, milo.kim@ti.com, balajitk@ti.com, gg@slimlogic.co.uk, linux-iio@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 1/2] ARM: dts: twl: Add GPADC data to device tree References: <1374226039-16943-1-git-send-email-oleksandr.kozaruk@ti.com> <1374226039-16943-2-git-send-email-oleksandr.kozaruk@ti.com> <51E94F97.40002@cogentembedded.com> <51E95DEB.7010702@ti.com> In-Reply-To: <51E95DEB.7010702@ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 51 Hello. On 07/19/2013 07:40 PM, Grygorii Strashko wrote: >>> GPADC is the general purpose ADC present on twl6030. >>> The dt data is interrupt used to trigger end of ADC >>> conversion. >>> Signed-off-by: Oleksandr Kozaruk >>> --- >>> arch/arm/boot/dts/twl6030.dtsi | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> diff --git a/arch/arm/boot/dts/twl6030.dtsi >>> b/arch/arm/boot/dts/twl6030.dtsi >>> index 2e3bd31..d7d4c28 100644 >>> --- a/arch/arm/boot/dts/twl6030.dtsi >>> +++ b/arch/arm/boot/dts/twl6030.dtsi >>> @@ -103,4 +103,10 @@ >>> compatible = "ti,twl6030-pwmled"; >>> #pwm-cells = <2>; >>> }; >>> + >>> + adc: gpadc { >> Read my lips: the node should be called just "adc", not "gpadc". > ^^^^^^^^^^^^ Are you sure? I didn't know how to express my disappointment from Oleksandr's inability to understand what I wanted to convey to him from 2 attempts... first, he changed the label instead of the node name, then he only dropped "twl6030_" prefix from the name. I should probably have been even more specific before. > Why? The name was selected according to the documentation on device "General > purpose analog-to-digital converter (GPADC)". Sigh, we simply don't care whether this ADC is general-purpose or not. The main thing it is ADC. > PS. Following your logic - "GPIO" need to renamed to "IO" everywhere ;P GPIO is well known and established abbreviation, contrasted to GPADC. Moreover, ePAPR spec lists "gpio" as a generic node name. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/