Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752735Ab3GSVIp (ORCPT ); Fri, 19 Jul 2013 17:08:45 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:58102 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466Ab3GSVIn (ORCPT ); Fri, 19 Jul 2013 17:08:43 -0400 MIME-Version: 1.0 In-Reply-To: References: <1374191339-10124-1-git-send-email-mcgrof@do-not-panic.com> From: "Luis R. Rodriguez" Date: Fri, 19 Jul 2013 14:08:21 -0700 X-Google-Sender-Auth: MQylXyqpdIZNBKhUmbh5Waz6hLY Message-ID: Subject: Re: [PATCH] backports: backport drvdata = NULL core driver fixes To: Alan Stern Cc: "backports@vger.kernel.org" , Hans de Goede , Julia Lawall , USB list , "linux-kernel@vger.kernel.org" , Jiri Slaby , Jiri Kosina , Felix Fietkau Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 19 On Fri, Jul 19, 2013 at 2:07 PM, Luis R. Rodriguez wrote: >> This is not a very good idea. Although setting drvdata to NULL allowed >> a lot of code to be removed, it also exposed a bunch of hidden bugs -- >> drivers were using the drvdata value even after their remove function >> returned. > > Eek, have we not SmPL'ify'd a proof yet to ensure code like this no > longer exists? Julia? :) Come to think of it, perhaps we should require *proof* with SmPL like this in future to avoid regressions ? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/