Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896Ab3GSVhB (ORCPT ); Fri, 19 Jul 2013 17:37:01 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:43856 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793Ab3GSVg7 (ORCPT ); Fri, 19 Jul 2013 17:36:59 -0400 X-Greylist: delayed 587 seconds by postgrey-1.27 at vger.kernel.org; Fri, 19 Jul 2013 17:36:59 EDT X-IronPort-AV: E=Sophos;i="4.89,704,1367964000"; d="scan'208";a="26677018" Date: Fri, 19 Jul 2013 23:27:09 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "Luis R. Rodriguez" cc: Alan Stern , "backports@vger.kernel.org" , Hans de Goede , Julia Lawall , USB list , "linux-kernel@vger.kernel.org" , Jiri Slaby , Jiri Kosina , Felix Fietkau Subject: Re: [PATCH] backports: backport drvdata = NULL core driver fixes In-Reply-To: Message-ID: References: <1374191339-10124-1-git-send-email-mcgrof@do-not-panic.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 25 On Fri, 19 Jul 2013, Luis R. Rodriguez wrote: > On Fri, Jul 19, 2013 at 2:07 PM, Luis R. Rodriguez > wrote: > >> This is not a very good idea. Although setting drvdata to NULL allowed > >> a lot of code to be removed, it also exposed a bunch of hidden bugs -- > >> drivers were using the drvdata value even after their remove function > >> returned. > > > > Eek, have we not SmPL'ify'd a proof yet to ensure code like this no > > longer exists? Julia? :) > > Come to think of it, perhaps we should require *proof* with SmPL like > this in future to avoid regressions ? Is it a concurrency problem? SmPL is not so good at that in the general case. One would have to know a specific case where other functions of the driver can be invoked after remove. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/