Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752882Ab3GSWp3 (ORCPT ); Fri, 19 Jul 2013 18:45:29 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:23995 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873Ab3GSWp1 (ORCPT ); Fri, 19 Jul 2013 18:45:27 -0400 Date: Sat, 20 Jul 2013 01:45:03 +0300 From: Dan Carpenter To: "zhangwei(Jovi)" Cc: Andrew Morton , Ingo Molnar , Steven Rostedt , Jens Axboe , Al Viro , Eric Dumazet , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2] relay: fix timer madness Message-ID: <20130719224502.GA5687@mwanda> References: <51DCC48E.8050003@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51DCC48E.8050003@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 22 On Wed, Jul 10, 2013 at 10:18:54AM +0800, zhangwei(Jovi) wrote: > @@ -339,6 +339,10 @@ static void wakeup_readers(unsigned long data) > { > struct rchan_buf *buf = (struct rchan_buf *)data; > wake_up_interruptible(&buf->read_wait); > + /* > + * Stupid polling for now: > + */ > + mod_timer(&buf->timer, HZ / 10); mod_timer() takes an offset so probably "jiffies + HZ / 10" was intended here and also below. Certainly passing "HZ / 10" doesn't make any kind of sense. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/