Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756772Ab3GVIZo (ORCPT ); Mon, 22 Jul 2013 04:25:44 -0400 Received: from www.linutronix.de ([62.245.132.108]:59520 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753959Ab3GVIZl (ORCPT ); Mon, 22 Jul 2013 04:25:41 -0400 Message-ID: <51ECEC7E.7000008@linutronix.de> Date: Mon, 22 Jul 2013 10:25:34 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130630 Icedove/17.0.7 MIME-Version: 1.0 To: ch.naveen@samsung.com CC: Rob Herring , Grant Likely , "linux-omap@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Tony Lindgren , Doug Anderson , Vivek Gautam , Kukjin Kim , Kishon Vijay Abraham I , Roger Quadros , George Cherian , Felipe Balbi Subject: Re: [PATCH] of: provide of_platform_unpopulate() References: <2333396.179421374298979822.JavaMail.weblogic@epml22> In-Reply-To: <2333396.179421374298979822.JavaMail.weblogic@epml22> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1593 Lines: 43 On 07/20/2013 07:42 AM, NAVEEN KRISHNA CHATRADHI wrote: > Hello Sebastian, Hello Naveen, > > I just did one more testing. > > In case of iio/adc/exynos_adc.c there is a bug in the remove path. > If I fix the bug in the driver, with below patch > > --- a/drivers/iio/adc/exynos_adc.c > +++ b/drivers/iio/adc/exynos_adc.c > @@ -375,14 +375,14 @@ static int exynos_adc_remove(struct platform_device *pdev) > struct iio_dev *indio_dev = platform_get_drvdata(pdev); > struct exynos_adc *info = iio_priv(indio_dev); > > - device_for_each_child(&pdev->dev, NULL, > - exynos_adc_remove_devices); > regulator_disable(info->vdd); > clk_disable_unprepare(info->clk); > writel(0, info->enable_reg); > iio_device_unregister(indio_dev); > free_irq(info->irq, info); > iio_device_free(indio_dev); > + device_for_each_child(&pdev->dev, NULL, > + exynos_adc_remove_devices); > > Even without your fix, I could configure it as a module and the rmmod, insmod are working fine. (no crash) I have no idea why you moved it. I haven't found any .dts with this binding but from the binding document I would assume that you do not have any memory resources and therefore you don't see that crash. > Regards, > Naveen Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/