Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932224Ab3GVOtb (ORCPT ); Mon, 22 Jul 2013 10:49:31 -0400 Received: from inx.pm.waw.pl ([195.116.170.130]:52949 "EHLO inx.pm.waw.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756343Ab3GVOt3 (ORCPT ); Mon, 22 Jul 2013 10:49:29 -0400 From: Krzysztof Halasa To: Ben Hutchings Cc: Jonas Gorski , , , , "David S. Miller" , Russell King , "Imre Kaloz" Subject: Re: [PATCH 1/2] arm: ixp4xx: set cohorent_dma_mask for ethernet platform devices References: <1374315339-31469-1-git-send-email-jogo@openwrt.org> <1374315339-31469-2-git-send-email-jogo@openwrt.org> <1374424823.2804.25.camel@deadeye.wl.decadent.org.uk> Date: Mon, 22 Jul 2013 16:49:27 +0200 In-Reply-To: <1374424823.2804.25.camel@deadeye.wl.decadent.org.uk> (Ben Hutchings's message of "Sun, 21 Jul 2013 17:40:23 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 16 Ben Hutchings writes: > I think the problem is that the platform device and the platform data > have not been properly separated. The machine-specific setup functions > should be passing the eth_plat_info and MAC ID into a common ixp4xx > function which would then create the platform device with the correct > DMA mask etc. That's also my idea. Will look at this. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/