Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757469Ab3GVPhO (ORCPT ); Mon, 22 Jul 2013 11:37:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65354 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752252Ab3GVPhN (ORCPT ); Mon, 22 Jul 2013 11:37:13 -0400 From: Nikola Pajkovsky To: Gu Zheng Cc: Kim , f2fs , linux-kernel Subject: Re: [PATCH] f2fs: use list_for_each rather than list_for_each_safe, in remove_orphan_inode() References: <51E8F7A6.7030708@cn.fujitsu.com> Date: Mon, 22 Jul 2013 17:36:45 +0200 In-Reply-To: <51E8F7A6.7030708@cn.fujitsu.com> (Gu Zheng's message of "Fri, 19 Jul 2013 16:24:06 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 40 Gu Zheng writes: > As we remove the target single node, so list_for_each is enought, in order to > clean up, we use list_for_each_entry instead. > > Signed-off-by: Gu Zheng > --- > fs/f2fs/checkpoint.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 290db04..87f7bc2 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -237,13 +237,12 @@ out: > > void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino) > { > - struct list_head *this, *next, *head; > + struct list_head *head; > struct orphan_inode_entry *orphan; > > mutex_lock(&sbi->orphan_inode_mutex); > head = &sbi->orphan_inode_list; > - list_for_each_safe(this, next, head) { > - orphan = list_entry(this, struct orphan_inode_entry, list); > + list_for_each_entry(orphan, head, list) { > if (orphan->ino == ino) { > list_del(&orphan->list); > kmem_cache_free(orphan_entry_slab, orphan); you have meant list_for_each_entry_safe, haven't you? -- Nikola -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/