Message-ID: <51ED6486.3080700@broadcom.com>
Date: Mon, 22 Jul 2013 09:57:42 -0700
From: "Christian Daudt" <csd@broadcom.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623
 Thunderbird/17.0.7
MIME-Version: 1.0
To: "Arend van Spriel" <arend@broadcom.com>
cc: "Lee Jones" <lee.jones@linaro.org>, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, arnd@arndb.de,
        linus.walleij@stericsson.com,
        "Grant Likely" <grant.likely@secretlab.ca>
Subject: Re: [PATCH 05/22] ARM: dts: bcm281xx: Remove '0x's from
 BCM11351 BRT DTS file
References: <1374490361-25769-1-git-send-email-lee.jones@linaro.org>
 <1374490361-25769-5-git-send-email-lee.jones@linaro.org>
 <51ED2D90.4020209@broadcom.com> <20130722133852.GA26801@laptop>
 <51ED3971.905@broadcom.com>
In-Reply-To: <51ED3971.905@broadcom.com>
Content-Type: text/plain;
 charset=utf-8;
 format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2682
Lines: 76

On 13-07-22 06:53 AM, Arend van Spriel wrote:
> On 07/22/2013 03:38 PM, Lee Jones wrote:
>> On Mon, 22 Jul 2013, Christian Daudt wrote:
>>
>>> On 13-07-22 03:52 AM, Lee Jones wrote:
>>>> Cc: Christian Daudt <csd@broadcom.com>
>>>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>>>> ---
>>>>   arch/arm/boot/dts/bcm11351-brt.dts | 6 +++---
>>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/bcm11351-brt.dts 
>>>> b/arch/arm/boot/dts/bcm11351-brt.dts
>>>> index 67ec524..fdace5d 100644
>>>> --- a/arch/arm/boot/dts/bcm11351-brt.dts
>>>> +++ b/arch/arm/boot/dts/bcm11351-brt.dts
>>>> @@ -27,18 +27,18 @@
>>>>           status = "okay";
>>>>       };
>>>> -    sdio0: sdio@0x3f180000 {
>>>> +    sdio0: sdio@3f180000 {
>>>>           max-frequency = <48000000>;
>>>>           status = "okay";
>>>>       };
>>>> -    sdio1: sdio@0x3f190000 {
>>>> +    sdio1: sdio@3f190000 {
>>>>           non-removable;
>>>>           max-frequency = <48000000>;
>>>>           status = "okay";
>>>>       };
>>>> -    sdio3: sdio@0x3f1b0000 {
>>>> +    sdio3: sdio@3f1b0000 {
>>>>           max-frequency = <48000000>;
>>>>           status = "okay";
>>>>       };
>>> Hi Lee,
>>>   Is this convention documented ? Someone called my attention to the
>>> fact that this dts files was inconsistent in its use of 0x in names,
>>> but I was not aware of a coding guideline for this.
>>
>> The best two places I can think of are:
>>
>> Documentation/devicetree/usage-model.txt
>> and
>> http://www.devicetree.org/Device_Tree_Usage
>
> And even those do not stick to a single convention, but that is what 
> can be expected of a twiki page :-p
[take 2 with in plain text]

Agreed. Quick search shows the following example on that page:
         pci@0x10180000 {
             compatible = "arm,versatile-pci-hostbridge", "pci";
             reg = <0x10180000 0x1000>;
             interrupts = <8 0>;
             bus-ranges = <0 0>;
         };

though it is the minority in the examples, ultimately having more 
examples following one convention than the other does not a standard 
make :) While I like this just for the consistency, it'd be nice to have 
something to point people to as this being the best practice for kernel 
dev. It would be good to have a DeviceTreeGuidelines along the lines of 
the CodingGuidelines file in the kernel tree itself, to get some 
consistency on this.


  Thanks,
    csd


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/