Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932848Ab3GVS3U (ORCPT ); Mon, 22 Jul 2013 14:29:20 -0400 Received: from mail-oa0-f43.google.com ([209.85.219.43]:33410 "EHLO mail-oa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932502Ab3GVS3R (ORCPT ); Mon, 22 Jul 2013 14:29:17 -0400 MIME-Version: 1.0 In-Reply-To: <1374512879.4990.19.camel@edumazet-glaptop> References: <1374311809-4155-1-git-send-email-freddy@asix.com.tw> <1374512879.4990.19.camel@edumazet-glaptop> Date: Mon, 22 Jul 2013 11:29:16 -0700 Message-ID: Subject: Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A From: Grant Grundler To: Eric Dumazet Cc: Freddy Xin , David Miller , netdev , linux-usb@vger.kernel.org, LKML , =?UTF-8?B?QVNJWCBMb3VpcyBb6JiH5aiB6Zm4XQ==?= , Allan Chou Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 23 On Mon, Jul 22, 2013 at 10:07 AM, Eric Dumazet wrote: ... > I guess that if a driver does not advertise NETIF_F_SG, this > skb_linearize() call is not needed : All frames reaching your xmit > function should already be linear As Ben Hutchings pointed out, hw_features is still setting this...but I'm not sure how that matters. ax88179_set_features() doesn't allow setting SG or TSO features. But I expect it would be "not too difficult" to add such that ethtool could set those features after boot. Or perhaps add a driver module parameter to set these features. I just guessing the skb_linearize() could be removed until set_features support for SG and/or TSO is added. Is that correct? thanks, grant -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/