Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901Ab3GVXgR (ORCPT ); Mon, 22 Jul 2013 19:36:17 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:42224 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751482Ab3GVXgQ (ORCPT ); Mon, 22 Jul 2013 19:36:16 -0400 From: Laurent Pinchart To: Guennadi Liakhovetski Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman , Vinod Koul , Sergei Shtylyov Subject: Re: [PATCH v2 04/15] DMA: shdma: make a pointer const Date: Tue, 23 Jul 2013 01:37:06 +0200 Message-ID: <2697597.tfSXoJkJMv@avalon> User-Agent: KMail/4.10.2 (Linux/3.8.13-gentoo; KDE/4.10.2; x86_64; ; ) In-Reply-To: References: <1374251374-30186-1-git-send-email-g.liakhovetski@gmx.de> <15445605.PE49oOgv4F@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 907 Lines: 26 Hi Guennadi, On Monday 22 July 2013 09:53:51 Guennadi Liakhovetski wrote: > On Sun, 21 Jul 2013, Laurent Pinchart wrote: > > On Friday 19 July 2013 18:29:29 Guennadi Liakhovetski wrote: > > > Platform data shouldn't be changed at run-time, so, pointers to it > > > should be const. > > > > If you move this patch to the beginning of the series you could make the > > pdata structures const in 02/15 and 03/15. > > Are these actually related? I think they can be made const regardless? Right, the compiler will probably not complain, as the platform data pointer introduced by patches 02 and 03 are cast to an unsigned long. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/