Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754171Ab3GWAcy (ORCPT ); Mon, 22 Jul 2013 20:32:54 -0400 Received: from mail-ve0-f173.google.com ([209.85.128.173]:52843 "EHLO mail-ve0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753753Ab3GWAcu (ORCPT ); Mon, 22 Jul 2013 20:32:50 -0400 MIME-Version: 1.0 In-Reply-To: References: <1367884221-20462-1-git-send-email-ccross@android.com> <1367884221-20462-14-git-send-email-ccross@android.com> <20130723010250.5a3465ec@xenia.leun.net> Date: Mon, 22 Jul 2013 17:32:48 -0700 X-Google-Sender-Auth: ECNA_oY6SoUhm2e2bnT0xdQayqI Message-ID: Subject: Re: 3.11-rc regression bisected: s2disk does not work (was Re: [PATCH v3 13/16] futex: use freezable blocking call) From: Linus Torvalds To: Colin Cross Cc: Michael Leun , lkml , Pavel Machek , "Rafael J. Wysocki" , Peter Zijlstra , Ingo Molnar , Andrew Morton , Mandeep Singh Baines , Oleg Nesterov , linux-nfs , Linux PM list , netdev , Tejun Heo , Darren Hart , Thomas Gleixner , Randy Dunlap , Al Viro Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 23 On Mon, Jul 22, 2013 at 4:55 PM, Colin Cross wrote: > > I think the right solution is to add a flag to the freezing task that > marks it unfreezable. I think PF_NOFREEZE would work, although it is > normally used on kernel threads, can you see if the attached patch > helps? Hmm. That does seem to be the right thing to do, but I wonder about the *other* callers of freeze_processes() IOW, kexec and friends. So maybe we should do this in {freeze|thaw}_processes() itself, and just make the rule be that the caller of freeze_processes() itself is obviously not frozen, and has to be the same one that then thaws things? Colin? Rafael? Comments? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/