Date: Tue, 23 Jul 2013 01:40:40 -0400 (EDT)
From: Vince Weaver <vince@deater.net>
To: Andi Kleen <andi@firstfloor.org>
cc: acme@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>, Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 1/2] tools, perf: Add a precise event qualifier v2
In-Reply-To: <1374501138-13496-1-git-send-email-andi@firstfloor.org>
Message-ID: <alpine.DEB.2.02.1307230137160.18617@pianoman.cluster.toy>
References: <1374501138-13496-1-git-send-email-andi@firstfloor.org>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 769
Lines: 23

On Mon, 22 Jul 2013, Andi Kleen wrote:

> From: Andi Kleen <ak@linux.intel.com>
> 
> Add a precise qualifier, like cpu/event=0x3c,precise=1/

So you're adding this to "events/" but not to "format/"?

This breaks the ABI, which specifies that the only fields
that can appear in a sysfs events specifier must exist under
the format directory.

This was what I worried about when I said people are going to start 
leaking perf tool specific events into the kernel sysfs tree.

This will break various existing programs.

Vince
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/