Date: Tue, 23 Jul 2013 09:39:50 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: len.brown@intel.com, pavel@ucw.cz, rjw@sisk.pl, tglx@linutronix.de,
        mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] x86, acpi: Fix wrong checking condition in
 acpi_register_lapic().
Message-ID: <20130723073950.GB13710@gmail.com>
References: <1374543541-4451-1-git-send-email-tangchen@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1374543541-4451-1-git-send-email-tangchen@cn.fujitsu.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1030
Lines: 34


* Tang Chen <tangchen@cn.fujitsu.com> wrote:

> We wanted to check if the acpi id is out of range. It should be:
> 	if (id >= (MAX_LOCAL_APIC)).

Does this have any practical impact, or can it wait until v3.12?

> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> ---
>  arch/x86/kernel/acpi/boot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index d81a972..2a15ae7 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -199,7 +199,7 @@ static void __cpuinit acpi_register_lapic(int id, u8 enabled)
>  {
>  	unsigned int ver = 0;
>  
> -	if (id >= (MAX_LOCAL_APIC-1)) {
> +	if (id >= (MAX_LOCAL_APIC)) {

The parentheses are now superfluous.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/