Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755952Ab3GWI4C (ORCPT ); Tue, 23 Jul 2013 04:56:02 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:55929 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755335Ab3GWIz6 (ORCPT ); Tue, 23 Jul 2013 04:55:58 -0400 Date: Tue, 23 Jul 2013 09:55:52 +0100 From: Lee Jones To: Tomasz Figa Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linus.walleij@stericsson.com, Kukjin Kim , linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 07/22] ARM: exynos: Remove '0x's from Exynos4110 DTSI file Message-ID: <20130723085552.GF26801@laptop> References: <1374490361-25769-1-git-send-email-lee.jones@linaro.org> <1374490361-25769-7-git-send-email-lee.jones@linaro.org> <2350088.9z671SCjFz@flatron> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2350088.9z671SCjFz@flatron> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1526 Lines: 48 On Mon, 22 Jul 2013, Tomasz Figa wrote: > Hi Lee, > > On Monday 22 of July 2013 11:52:26 Lee Jones wrote: > > Cc: Kukjin Kim > > Cc: linux-samsung-soc@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > arch/arm/boot/dts/exynos4210.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/exynos4210.dtsi > > b/arch/arm/boot/dts/exynos4210.dtsi index b7f358a..53e2527 100644 > > --- a/arch/arm/boot/dts/exynos4210.dtsi > > +++ b/arch/arm/boot/dts/exynos4210.dtsi > > @@ -72,7 +72,7 @@ > > }; > > }; > > > > - clock: clock-controller@0x10030000 { > > + clock: clock-controller@10030000 { > > compatible = "samsung,exynos4210-clock"; > > reg = <0x10030000 0x20000>; > > #clock-cells = <1>; > > This looks fine, but please fix commit message - it should be Exynos4210. > Also some explanation why this change is needed would be good, even if > it's obvious. Hi Tomasz, I'm happy to fixup the $SUBJECT line, but do we really have to enter an explanation if it's obvious? Seems a little belt and braces. Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/