Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756219Ab3GWJkJ (ORCPT ); Tue, 23 Jul 2013 05:40:09 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:38202 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755617Ab3GWJkG (ORCPT ); Tue, 23 Jul 2013 05:40:06 -0400 Date: Tue, 23 Jul 2013 10:39:50 +0100 From: Russell King - ARM Linux To: Sascha Hauer Cc: Jean-Francois Moine , alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , Rob Herring , devicetree-discuss@vger.kernel.org, Mark Brown Subject: Re: [alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage Message-ID: <20130723093950.GR24642@n2100.arm.linux.org.uk> References: <20130723104615.3696f1a9@armhf> <20130723085346.GQ24642@n2100.arm.linux.org.uk> <20130723090820.GN9434@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130723090820.GN9434@pengutronix.de> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1452 Lines: 35 On Tue, Jul 23, 2013 at 11:08:20AM +0200, Sascha Hauer wrote: > On Tue, Jul 23, 2013 at 09:53:46AM +0100, Russell King - ARM Linux wrote: > > On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote: > > > The kirkwood i2s driver is used without DT in the Kirkwood machine. > > > This patch adds a DT compatible definition for use in other Marvell > > > machines as the Armada 88AP510 (Dove). > > > > Yet again, this illustrates why converting to DT causes backwards > > steps in drivers: the conversion of devm_clk_get() to of_clk_get() > > necessitates a clk_put(). > > > > Can someone please provide a devm_of_clk_get() function before we > > accept any more patches doing this kind of thing? > > The question is why isn't regular [devm_]clk_get used here? I don't know > what the Marvell stuff is doing here, but if the clk stuff is > implemented correctly then > > np = pdev->dev.of_node; > priv->clk = of_clk_get(np, 0); > > and > > devm_clk_get(&pdev->dev, "label"); > > should both work You tell me - I keep seeing patches on this list converting drivers from using devm_clk_get() to using of_clk_get(). Maybe of_clk_get() should be marked deprecated to stop people using it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/