Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756294Ab3GWJv4 (ORCPT ); Tue, 23 Jul 2013 05:51:56 -0400 Received: from merlin.infradead.org ([205.233.59.134]:36712 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755977Ab3GWJvx (ORCPT ); Tue, 23 Jul 2013 05:51:53 -0400 Date: Tue, 23 Jul 2013 11:51:24 +0200 From: Peter Zijlstra To: Ingo Molnar Cc: Tim Chen , Ingo Molnar , Andrea Arcangeli , Mel Gorman , "Shi, Alex" , Andi Kleen , Andrew Morton , Michel Lespinasse , Davidlohr Bueso , "Wilcox, Matthew R" , Dave Hansen , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm Subject: Re: Performance regression from switching lock to rw-sem for anon-vma tree Message-ID: <20130723095124.GW27075@twins.programming.kicks-ass.net> References: <20130627083651.GA3730@gmail.com> <1372366385.22432.185.camel@schen9-DESK> <1372375873.22432.200.camel@schen9-DESK> <20130628093809.GB29205@gmail.com> <1372453461.22432.216.camel@schen9-DESK> <20130629071245.GA5084@gmail.com> <1372710497.22432.224.camel@schen9-DESK> <20130702064538.GB3143@gmail.com> <1373997195.22432.297.camel@schen9-DESK> <20130723094513.GA24522@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130723094513.GA24522@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 16 On Tue, Jul 23, 2013 at 11:45:13AM +0200, Ingo Molnar wrote: > Why not just try the delayed addition approach first? The spinning is time > limited AFAICS, so we don't _have to_ recognize those as writers per se, > only if the spinning fails and it wants to go on the waitlist. Am I > missing something? > > It will change patterns, it might even change the fairness balance - but > is a legit change otherwise, especially if it helps performance. Be very careful here. Some people (XFS) have very specific needs. Walken and dchinner had a longish discussion on this a while back. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/