Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756731Ab3GWLhK (ORCPT ); Tue, 23 Jul 2013 07:37:10 -0400 Received: from smtp.citrix.com ([66.165.176.89]:28633 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756254Ab3GWLhI (ORCPT ); Tue, 23 Jul 2013 07:37:08 -0400 X-IronPort-AV: E=Sophos;i="4.89,727,1367971200"; d="scan'208";a="38669363" Date: Tue, 23 Jul 2013 12:37:04 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Konrad Rzeszutek Wilk CC: Julien Grall , , , , , , Subject: Re: [PATCH v4] xen/arm: enable PV control for ARM In-Reply-To: <5228e08a-1cdb-4240-b10f-9ad690c94ac4@email.android.com> Message-ID: References: <1374529321-12955-1-git-send-email-julien.grall@linaro.org> <5228e08a-1cdb-4240-b10f-9ad690c94ac4@email.android.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1737 Lines: 45 On Mon, 22 Jul 2013, Konrad Rzeszutek Wilk wrote: > Julien Grall wrote: > >Enable power management from the toolstack for ARM guest. > > > >Signed-off-by: Julien Grall > > > >--- > > Changes in v4: > > - Divide the patch in 2 distinct parts > > Changes in v3: > > - Fix condition to compile cpu_hotplug.o > > Changes in v2: > > - Don't compile xen/cpu_hotplug.o with ARM64 > >--- > > drivers/xen/Makefile | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > >diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > >index a609353..f185e8d 100644 > >--- a/drivers/xen/Makefile > >+++ b/drivers/xen/Makefile > >@@ -1,9 +1,8 @@ > > ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),) > >-obj-y += manage.o > > obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o > > endif > > obj-$(CONFIG_X86) += fallback.o > >-obj-y += grant-table.o features.o events.o balloon.o time.o > >+obj-y += grant-table.o features.o events.o balloon.o time.o manage.o > > obj-y += xenbus/ > > > > nostackp := $(call cc-option, -fno-stack-protector) > > The patch looks Ok but the description is off. Power management is the term used for cpu freq, C states and P states. While this patch touches none of that. > That's a very x86-centric view of the world, but it's true that manage.c is about shutdown, restart and other operations that don't fit under "power management". It could benefit from a better description. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/