Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757426Ab3GWMoJ (ORCPT ); Tue, 23 Jul 2013 08:44:09 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:39836 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757225Ab3GWMoH (ORCPT ); Tue, 23 Jul 2013 08:44:07 -0400 Date: Tue, 23 Jul 2013 14:44:02 +0200 From: Frederic Weisbecker To: Don Zickus Cc: Peter Zijlstra , LKML , Jiri Olsa , Namhyung Kim , Ingo Molnar , Arnaldo Carvalho de Melo , Stephane Eranian , "Srivatsa S. Bhat" , Anish Singh Subject: Re: [PATCH 8/8] watchdog: Remove hack to make full dynticks working Message-ID: <20130723124400.GA10278@somewhere> References: <1374539466-4799-1-git-send-email-fweisbec@gmail.com> <1374539466-4799-9-git-send-email-fweisbec@gmail.com> <20130723123331.GE126784@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130723123331.GE126784@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 29 On Tue, Jul 23, 2013 at 08:33:31AM -0400, Don Zickus wrote: > On Tue, Jul 23, 2013 at 02:31:06AM +0200, Frederic Weisbecker wrote: > > A perf event can be used without forcing the tick to > > stay alive if it doesn't use a frequency but a sample > > period and if it doesn't throttle (raise storm of events). > > > > Since the lockup detector neither use a perf event frequency > > nor should ever throttle due to its high period, it can now > > run concurrently with the full dynticks feature. > > Thanks. Dumb question, I keep wondering if the lockup detector would be > better or worse off if it used the perf event frequency as opposed to > using a sample period? The idea is it could follow the varying cpu > frequencies better (and probably simplify some of the code too). > > Acked-by: Don Zickus Thanks! IIRC we tried that and I believe the issue was that perf did not support frequency below 1. So probably the limitation was that it had to fire at least once per sec. Also if you do that, we fall into the full dynticks problem again. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/