Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757784Ab3GWOxK (ORCPT ); Tue, 23 Jul 2013 10:53:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34935 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757575Ab3GWOxI (ORCPT ); Tue, 23 Jul 2013 10:53:08 -0400 Date: Tue, 23 Jul 2013 07:54:19 -0700 From: Greg KH To: Lv Zheng Cc: "Rafael J. Wysocki" , Len Brown , Corey Minyard , Zhao Yakui , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net Subject: Re: [PATCH 01/13] ACPI/IPMI: Fix potential response buffer overflow Message-ID: <20130723145419.GA12065@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1266 Lines: 31 On Tue, Jul 23, 2013 at 04:08:59PM +0800, Lv Zheng wrote: > This patch enhances sanity checks on message size to avoid potential buffer > overflow. > > The kernel IPMI message size is IPMI_MAX_MSG_LENGTH(272 bytes) while the > ACPI specification defined IPMI message size is 64 bytes. The difference > is not handled by the original codes. This may cause crash in the response > handling codes. > This patch fixes this gap and also combines rx_data/tx_data to use single > data/len pair since they need not be seperated. > > Signed-off-by: Lv Zheng > Reviewed-by: Huang Ying > --- > drivers/acpi/acpi_ipmi.c | 100 ++++++++++++++++++++++++++++------------------ > 1 file changed, 61 insertions(+), 39 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. Same goes for the other patches you sent in this thread... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/