Message-ID: <51EEAD3E.1040606@nvidia.com>
Date: Tue, 23 Jul 2013 09:20:14 -0700
From: Stephen Warren <swarren@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6
MIME-Version: 1.0
To: Laxman Dewangan <ldewangan@nvidia.com>
CC: linus.walleij@linaro.org, grant.likely@linaro.org, rob.herring@calxeda.com,
        rob@landley.net, devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        kishon@ti.com, j-keerthy@ti.com, gg@slimlogic.co.uk
Subject: Re: [PATCH V4] gpio: palmas: add dt support
References: <1374564964-1281-1-git-send-email-ldewangan@nvidia.com>
In-Reply-To: <1374564964-1281-1-git-send-email-ldewangan@nvidia.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1070
Lines: 32

On 07/23/2013 12:36 AM, Laxman Dewangan wrote:
> Add of_device_id table for Palma GPIO to be enable the
> driver from DT file.
> 
> The driver can be registered from DT file as:
> 	palmas: tps65913@58 {
> 		:::::::::::
> 		palmas_gpio: palmas_gpio {
> 			compatible = "ti,palmas-gpio";
> 			gpio-controller;
> 			#gpio-cells = <2>;
> 		};
> 	};

The binding at least,
Acked-by: Stephen Warren <swarren@nvidia.com>

> diff --git a/drivers/gpio/gpio-palmas.c b/drivers/gpio/gpio-palmas.c

>  #ifdef CONFIG_OF_GPIO
> -	palmas_gpio->gpio_chip.of_node = palmas->dev->of_node;
> +	palmas_gpio->gpio_chip.of_node = pdev->dev.of_node;
>  #endif

That still scares me slightly, in case someone is already using this
driver and this changes how it works, and it breaks something, but I
don't think anyone is, so this should be OK too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/