Date: Tue, 23 Jul 2013 12:37:12 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-kernel@vger.kernel.org, Peng Tao <tao.peng@emc.com>,
        Andreas Dilger <andreas.dilger@intel.com>
Subject: Re: [PATCH 02/48] staging/lustre/obdclass: restore lu_ref
Message-ID: <20130723193712.GA9385@kroah.com>
References: <1374509230-3324-1-git-send-email-bergwolf@gmail.com>
 <1374509230-3324-3-git-send-email-bergwolf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1374509230-3324-3-git-send-email-bergwolf@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 750
Lines: 19

On Tue, Jul 23, 2013 at 12:06:23AM +0800, Peng Tao wrote:
> lu_ref.[ch] were mistakenly removed by coan2. Add them back and guard
> with CONFIG_LUSTRE_DEBUG_LU_REF_CHECK.

Ick, why?  Why not use the in-kernel infrastructure for this type of
thig, _iff_ you really need it.

Why do you need this at all, isn't the reference code fully debugged by
now, given that this has been running for years?  I would only expect to
see something like this in new code that is still being developed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/