Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934176Ab3GWTyN (ORCPT ); Tue, 23 Jul 2013 15:54:13 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:48818 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933618Ab3GWTyL (ORCPT ); Tue, 23 Jul 2013 15:54:11 -0400 MIME-Version: 1.0 In-Reply-To: <1374576609-27748-3-git-send-email-g.liakhovetski@gmx.de> References: <1374576609-27748-1-git-send-email-g.liakhovetski@gmx.de> <1374576609-27748-3-git-send-email-g.liakhovetski@gmx.de> Date: Wed, 24 Jul 2013 04:54:09 +0900 Message-ID: Subject: Re: [PATCH v4 02/15] DMA: shdma: add r8a7740 DMAC data to the device ID table From: Magnus Damm To: Guennadi Liakhovetski Cc: linux-kernel , Simon Horman , Laurent Pinchart , Vinod Koul , SH-Linux , Sergei Shtylyov , Guennadi Liakhovetski Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 44 Hi Guennadi, Thanks for your efforts on this. On Tue, Jul 23, 2013 at 7:49 PM, Guennadi Liakhovetski wrote: > This configuration data will be re-used, when DMAC DT support is added to > r8a7740, DMAC platform data in setup-r8a7740.c will be removed. > > Signed-off-by: Guennadi Liakhovetski > --- > > v4: make struct sh_dmae_pdata r8a7740_dma_pdata "const" > [snip] > --- /dev/null > +++ b/drivers/dma/sh/shdma-r8a7740.c > @@ -0,0 +1,95 @@ > +#include > + > +#include > +#include Including stuff from isn't really compatible with MULTIPLATFORM, so please don't write new code like this. Actually we don't want any code under drivers/ to include stuff from the mach directory. I suggest that you arrange your code in a way so the C version of DMAC support has tables with slave ids as usual under arch/arm/mach-shmobile/, but the DT bits that operate independently of C stay in drivers/... Over time we will get rid of the C version, and until that happens the DT and C version can coexist in parallel. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/