Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934400Ab3GXAJt (ORCPT ); Tue, 23 Jul 2013 20:09:49 -0400 Received: from mail-ee0-f51.google.com ([74.125.83.51]:46508 "EHLO mail-ee0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013Ab3GXAJr (ORCPT ); Tue, 23 Jul 2013 20:09:47 -0400 From: Fabio Baltieri To: Johannes Berg , "John W. Linville" Cc: linux-wireless@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fabio Baltieri Subject: [PATCH] mac80211: use oneshot blink API for LED triggers Date: Wed, 24 Jul 2013 02:09:40 +0200 Message-Id: <1374624581-6012-1-git-send-email-fabio.baltieri@gmail.com> X-Mailer: git-send-email 1.8.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1065 Lines: 34 Hi Johannes, John, This patch changes the mac80211 LED driver to use the generic oneshot LED API. The current mac80211 blink code seems to lead to very short tx blinks and toggles the LED on tx. The oneshot API ensure a complete LED on-off cycle for each blink event, thus getting a better result for an activity indicator: one visible blink for sporadic events and a steady on-off blink sequence on constant traffic. Would you consider this patch for wireless-next? Thanks, Fabio Fabio Baltieri (1): mac80211: use oneshot blink API for LED triggers net/mac80211/ieee80211_i.h | 1 - net/mac80211/led.c | 21 +++++++++------------ net/mac80211/led.h | 2 +- net/mac80211/status.c | 2 +- net/mac80211/tx.c | 1 - 5 files changed, 11 insertions(+), 16 deletions(-) -- 1.8.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/