Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758134Ab3GXAKd (ORCPT ); Tue, 23 Jul 2013 20:10:33 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:37263 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758104Ab3GXAKa (ORCPT ); Tue, 23 Jul 2013 20:10:30 -0400 MIME-Version: 1.0 In-Reply-To: <20130723124023.GX9858@sirena.org.uk> References: <1374281962-3786-1-git-send-email-eu@felipetonello.com> <20130722000157.GI9858@sirena.org.uk> <20130723124023.GX9858@sirena.org.uk> Date: Tue, 23 Jul 2013 17:10:29 -0700 Message-ID: Subject: Re: [PATCH] ALSA: SoC: Added jack detection kcontrol support From: Felipe Tonello To: Mark Brown Cc: alsa-devel@alsa-project.org, LiamGirdwoodlgirdwood@gmail.com, JaroslavKyselaperex@perex.cz, TakashiIwaitiwai@suse.de, linux-kernel@vger.kernel.org, "Felipe F. Tonello" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 33 Hi Mark, On Tue, Jul 23, 2013 at 5:40 AM, Mark Brown wrote: > On Mon, Jul 22, 2013 at 02:11:44PM -0700, Felipe Tonello wrote: > >> My question is: Why ALSA Jack support uses evdev input events to >> notify user-space? Is there any user-space relying on that? If no, I >> would like to change ALSA Jack implementation to only use KControl and >> remove specific implementations. > > This was the existing kernel API at the time that the code was added - > I beleive people had been doing that for simple switches that detect the > physical presence of a jack since it looks exactly like a button from a > hardware point of view. See the original commit adding the code. I saw it. I don't know what you think is the best way to go. I'm not sure if someone is using this input event API, since even PulseAudio even declined that implementation due KControl implementation. I'm thinking in re-implement core/jack.c using only kcontrol for reporting status and leaving input events only for keys (which is already implemented). This will break compatibility if any user-space checks for jack status using input events, but again, is anyone using this? Regards, Felipe Tonello -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/