Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751342Ab3GXC3Q (ORCPT ); Tue, 23 Jul 2013 22:29:16 -0400 Received: from mail-oa0-f50.google.com ([209.85.219.50]:40258 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833Ab3GXC3O (ORCPT ); Tue, 23 Jul 2013 22:29:14 -0400 MIME-Version: 1.0 In-Reply-To: <20130723.164656.1794159338719943519.davem@davemloft.net> References: <1374518841.4990.26.camel@edumazet-glaptop> <1374522471.1635.48.camel@bwh-desktop.uk.level5networks.com> <1374559827.4990.143.camel@edumazet-glaptop> <20130723.164656.1794159338719943519.davem@davemloft.net> Date: Tue, 23 Jul 2013 19:29:13 -0700 Message-ID: Subject: Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A From: Grant Grundler To: David Miller Cc: Eric Dumazet , Ben Hutchings , oliver@neukum.org, Freddy Xin , netdev , linux-usb@vger.kernel.org, LKML , =?UTF-8?B?QVNJWCBMb3VpcyBb6JiH5aiB6Zm4XQ==?= , Allan Chou Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 22 On Tue, Jul 23, 2013 at 4:46 PM, David Miller wrote: ... > A quick scan shows that smsc75xx, smsc95xx, and ax88179_178a all have > this problem. > > Instead of the patch starting this thread, I'd like to see one that > hits all three drivers and removes all SG and TSO features bits from > both the ->features _and_ ->hw_features settings. Since you are asking to remove TSO, do you also want skb_linearize() calls in ax88179_178a.c and smsc75xx.c removed as well? Not part of the original patch - but based on this thread, Eric seems to think calling skb_linearize isn't necessary or helpful either. cheers, grant -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/