Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650Ab3GXJEz (ORCPT ); Wed, 24 Jul 2013 05:04:55 -0400 Received: from mail-qe0-f46.google.com ([209.85.128.46]:41937 "EHLO mail-qe0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758Ab3GXJEx (ORCPT ); Wed, 24 Jul 2013 05:04:53 -0400 Message-ID: <51EF980C.5010203@gmail.com> Date: Wed, 24 Jul 2013 09:02:04 +0000 From: =?UTF-8?B?IkrDs2hhbm4gQi4gR3XDsG11bmRzc29uIg==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Eric Sandeen CC: Theodore Tso , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?IkrDsw==?= =?UTF-8?B?aGFubiBCLiBHdcOwbXVuZHNzb24i?= Subject: Re: [PATCH 1/1] ext4: Fix Opts: (null) References: <1374531868-1800-1-git-send-email-johannbg@fedoraproject.org> <51EF3990.4010901@redhat.com> In-Reply-To: <51EF3990.4010901@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1073 Lines: 39 On 07/24/2013 02:18 AM, Eric Sandeen wrote: > Have you tested it? What's the difference in output? - ext4_msg(sb, KERN_INFO, "mounted filesystem with%s. " - "Opts: %s%s%s", descr, sbi->s_es->s_mount_opts, + ext4_msg(sb, KERN_INFO, "mounted filesystem with%s " + "%s%s%s mount option(s)", descr, sbi->s_es->s_mount_opts, *sbi->s_es->s_mount_opts ? "; " : "", orig_data); From mounted filesystem with Opts: (null) re-mounted. Opts:(null) To mounted filesystem with (null) mount option(s) re-mounted (null) mount option(s) That (null) could change to no or none I suppose but it still feels a bit off thou maybe this output sample would be better? if = (null) mounted filesystem re-mounted filesystem elif mounted filesystem with x,y.x mount option(s) re-mounted filesystem with x,y.x mount option(s) JBG -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/