Date: Wed, 24 Jul 2013 15:15:27 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
        linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
        Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH V8 13/15] perf tools: expand
 perf_event__synthesize_sample()
Message-ID: <20130724131526.GD4203@krava.brq.redhat.com>
References: <1374144177-24762-1-git-send-email-adrian.hunter@intel.com>
 <1374144177-24762-14-git-send-email-adrian.hunter@intel.com>
 <20130724125025.GA4203@krava.brq.redhat.com>
 <51EFD368.2080901@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51EFD368.2080901@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1014
Lines: 39

On Wed, Jul 24, 2013 at 04:15:20PM +0300, Adrian Hunter wrote:

SNIP

> >> +	}
> >> +
> >> +	if (type & PERF_SAMPLE_REGS_USER) {
> >> +		if (sample->user_regs.regs && sample_regs_user) {
> >> +			*array++ = sample_regs_user;
> > 
> > it's 'enum perf_sample_regs_abi' value that goes here ^^^
> > 
> > I guess for now it could be hardcoded like:
> > 
> > #if defined(__x86_64__)
> > abi = PERF_SAMPLE_REGS_ABI_64
> > #else
> > #if defined(__i386__)
> > abi = PERF_SAMPLE_REGS_ABI_64

ugh, PERF_SAMPLE_REGS_ABI_32 ^^^ of course ;-)

> > #endif
> > WARN()
> > #endif
> 
> Thanks for reviewing this.
> 
> Why isn't it better to leave it as a parameter?

np, you could have it as parameter.. but I guess for now
you'll endup with above code in the upper layer anyway

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/