Date: Wed, 24 Jul 2013 08:04:44 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Michal Hocko <mhocko@suse.cz>, devel@driverdev.osuosl.org,
        konrad.wilk@oracle.com, Piotr Sarna <p.sarna@partner.samsung.com>,
        linux-kernel@vger.kernel.org, bob.liu@oracle.com,
        Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] zcache: fix "zcache=" kernel parameter
Message-ID: <20130724150444.GE15095@kroah.com>
References: <1374245201-24474-1-git-send-email-p.sarna@partner.samsung.com>
 <7560549.NYTHa4SYx0@amdc1032>
 <20130724114157.GB3976@dhcp22.suse.cz>
 <4003586.oV5ROrQ3Ke@amdc1032>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4003586.oV5ROrQ3Ke@amdc1032>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2172
Lines: 62

On Wed, Jul 24, 2013 at 01:54:56PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> On Wednesday, July 24, 2013 01:41:57 PM Michal Hocko wrote:
> > On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote:
> > > 
> > > Hi,
> > > 
> > > On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> > > > On Wed 24-07-13 12:02:35, Michal Hocko wrote:
> > > > > I have posted a similar fix quite some time ago and I guess Greg should
> > > > > already have it.
> > > > 
> > > > For reference https://lkml.org/lkml/2013/6/26/410
> > > 
> > > There was a reply from Greg:
> > > 
> > > 	https://lkml.org/lkml/2013/6/26/410
> > 
> > I guess you meant https://lkml.org/lkml/2013/6/26/569
> 
> Uh, yes.
> 
> > > and it seems that Greg's request has not been fullfilled.
> > 
> > Bob Liu has resent the patch (I cannot find the email in the archive).
> 
> Indeed, I've found it here:
> 
> http://comments.gmane.org/gmane.linux.kernel.mm/102484
> 
> > > Anyway Piotr's patch seems to be more complete:
> > > - it also fixes case in which invalid "zcache=" option is given (returns
> > >   an error value 1 while with your patch the code still erronously retuns 0)
> > > - it prints information about compressor type being used when "zcache="
> > >   option is used (your patch skips it due to addition of "goto out_alloc")
> > 
> > I do not care which one will make it I just pointed out that there is
> > another patch dealing with the same and it is a question how far that
> > one went.
> 
> OK.
> 
> Greg, could you please pick Piotr's patch?

I'll get to it.  As no one labled it with "staging" at the front of the
patch, it missed my sweep of all needed staging patches, and fell into
the "I'll get to them soon" portion of my week.

Also, as this is staging code, it really isn't that important, otherwise
people would have worked harder to get it out of that portion of the
tree :)

{hint...}

Don't worry, it's not lost,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/