Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754421Ab3GXQ1W (ORCPT ); Wed, 24 Jul 2013 12:27:22 -0400 Received: from mail-ob0-f179.google.com ([209.85.214.179]:46155 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101Ab3GXQ1T (ORCPT ); Wed, 24 Jul 2013 12:27:19 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130709203927.31676.35169.stgit@amt.stowe> <1373404695.18560.17.camel@dabdike> <1373436657.7970.1.camel@dabdike> Date: Wed, 24 Jul 2013 10:27:18 -0600 Message-ID: Subject: Re: [PATCH 0/3] [SCSI] megaraid: Remove local (struct pci_dev) pdev's From: Myron Stowe To: adam radford Cc: James Bottomley , Myron Stowe , Neela Syam Kolli , linux-scsi , linux-pci , linux-kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2699 Lines: 70 Well??? I responded yesterday but I still don't see it on the list so at the expense of some getting a double response I'll try again ... On Mon, Jul 22, 2013 at 6:27 PM, adam radford wrote: > On Tue, Jul 9, 2013 at 11:10 PM, James Bottomley > wrote: >> On Tue, 2013-07-09 at 15:12 -0700, adam radford wrote: >>> On Tue, Jul 9, 2013 at 2:18 PM, James Bottomley >>> > Adam, you do drive by coding on this for LSI ... ack or reject, please. >> >>> I have just now located my box of MegaRAID Parallel SCSI controllers. >>> I will review and test the patch series from Myron and respond by next Monday. >> >> Thanks, >> >> James >> >> > > Unfortunately my box of MegaRAID Parallel SCSI controllers only > contains only cards intended for megaraid_mbox.c (I tested all 20 of > them), > > and does not contain any of the following really old Symbios based > megaraid cards: > > static struct pci_device_id megaraid_pci_tbl[] = { > {PCI_VENDOR_ID_AMI, PCI_DEVICE_ID_AMI_MEGARAID, > PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, > {PCI_VENDOR_ID_AMI, PCI_DEVICE_ID_AMI_MEGARAID2, > PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, > {PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_AMI_MEGARAID3, > PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, > {0,} > }; > > which I had located previously before the company headquarters moved. > I cannot currently locate any of the above 3 controllers anywhere at > LSI headquarters after an exhaustive search, so I cannot test the > patches to megaraid.c from Myron @ RedHat. Adam: Thanks for looking/trying. > > Myron, do you actually have the hardware and have you tested the > patches yourself ? No, the closest to the above that I have access to is a NEC platform with a PCI_VENDOR_ID_NCR vendor's PCI_DEVICE_ID_AMI_MEGARAID3 device. I stumbled onto the issue because I want to get rid of the driver's use of 'struct pci_dev'. It seems, from my looking, to be the only driver that keeps local copies of such, and upon further investigation I noticed that the intended use of the local copies is flawed to the point that keeping them makes no sense (which further supported my desire to get rid of them). Myron > > -Adam > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/