Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754653Ab3GXQhi (ORCPT ); Wed, 24 Jul 2013 12:37:38 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:46181 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753679Ab3GXQhh (ORCPT ); Wed, 24 Jul 2013 12:37:37 -0400 Date: Wed, 24 Jul 2013 20:37:34 +0400 From: Cyrill Gorcunov To: Andy Lutomirski Cc: Linux MM , LKML , Pavel Emelyanov , Andrew Morton , Matt Mackall , Xiao Guangrong , Marcelo Tosatti , KOSAKI Motohiro , Stephen Rothwell Subject: Re: [PATCH] mm: Save soft-dirty bits on swapped pages Message-ID: <20130724163734.GE24851@moon> References: <20130724160826.GD24851@moon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 21 On Wed, Jul 24, 2013 at 09:23:14AM -0700, Andy Lutomirski wrote: > On Wed, Jul 24, 2013 at 9:08 AM, Cyrill Gorcunov wrote: > > Andy Lutomirski reported that in case if a page with _PAGE_SOFT_DIRTY > > bit set get swapped out, the bit is getting lost and no longer > > available when pte read back. > > Potentially silly question (due to my completely lack of understanding > of how swapping works in Linux): what about file-backed pages? > (Arguably these would be best supported by filesystems instead of by > the core vm, in which case it might make sense to drop soft-dirty > support for these pages entirely.) Hi Andy, if I understand you correctly "file-backed pages" are carried in pte with _PAGE_FILE bit set and the swap soft-dirty bit won't be used on them but _PAGE_SOFT_DIRTY will be set on write if only I've not missed something obvious (Pavel?). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/