Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751863Ab3GXROV (ORCPT ); Wed, 24 Jul 2013 13:14:21 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:54830 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991Ab3GXROT (ORCPT ); Wed, 24 Jul 2013 13:14:19 -0400 Date: Wed, 24 Jul 2013 22:43:47 +0530 From: "Naveen N. Rao" To: Borislav Petkov Cc: LKML , Borislav Petkov , Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck , Len Brown , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org Subject: Re: [PATCH] APEI/ERST: Fix error message formatting Message-ID: <20130724171347.GB29756@naverao1-tp.watson.ibm.com> References: <1374526866-6813-1-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374526866-6813-1-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13072417-5490-0000-0000-000003E0DF85 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1948 Lines: 57 On 2013/07/22 11:01PM, Borislav Petkov wrote: > From: Borislav Petkov > > [ 5.525861] ERST: Can not request iomem region <0x c7eff000-0x c7f00000> for ERST. > > This needs to have leading zeroes. Make it so. > > Signed-off-by: Borislav Petkov > Cc: Anton Vorontsov > Cc: Colin Cross > Cc: Kees Cook > Cc: Tony Luck > Cc: Len Brown > Cc: "Rafael J. Wysocki" > Cc: linux-acpi@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/acpi/apei/erst.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c > index 88d0b0f9f92b..1126afeb7e22 100644 > --- a/drivers/acpi/apei/erst.c > +++ b/drivers/acpi/apei/erst.c > @@ -1168,7 +1168,7 @@ static int __init erst_init(void) > r = request_mem_region(erst_erange.base, erst_erange.size, "APEI ERST"); > if (!r) { > pr_err(ERST_PFX > - "Can not request iomem region <0x%16llx-0x%16llx> for ERST.\n", > + "Can not request iomem region <0x%016llx-0x%016llx> for ERST.\n", > (unsigned long long)erst_erange.base, > (unsigned long long)erst_erange.base + erst_erange.size); > rc = -EIO; Acked-by: Naveen N. Rao While looking at this, I noticed that we seem to be using varying field widths in our APEI code: - einj.c has two instances using %#010llx. - apei-base.c uses widths of 10 (4 bytes) and 6 (2 bytes). Not sure if these are intentional and those fields truly aren't 64-bit (as suggested by the usage of long long int). Regards, Naveen > -- > 1.8.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/