Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198Ab3GXSav (ORCPT ); Wed, 24 Jul 2013 14:30:51 -0400 Received: from smtpauth12.mfg.siteprotect.com ([64.26.60.150]:51677 "EHLO smtpauth02.mfg.siteprotect.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750933Ab3GXSat (ORCPT ); Wed, 24 Jul 2013 14:30:49 -0400 Date: Wed, 24 Jul 2013 14:31:44 -0400 (EDT) From: Vince Weaver X-X-Sender: vince@pianoman.cluster.toy To: Andi Kleen cc: Sasha Levin , Andi Kleen , acme@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Stephane Eranian , torvalds@linux-foundation.org, trinity@vger.kernel.org Subject: Re: [PATCH 1/2] tools, perf: Add a precise event qualifier v2 In-Reply-To: <20130724013315.GU6123@two.firstfloor.org> Message-ID: References: <1374501138-13496-1-git-send-email-andi@firstfloor.org> <20130723060108.GA18396@tassilo.jf.intel.com> <20130723225150.GT6123@two.firstfloor.org> <51EF222D.9070909@oracle.com> <20130724013315.GU6123@two.firstfloor.org> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-CTCH-Spam: Unknown X-CTCH-RefID: str=0001.0A020206.51F01D59.00B8,ss=1,re=0.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 23 On Wed, 24 Jul 2013, Andi Kleen wrote: > On Tue, Jul 23, 2013 at 08:39:09PM -0400, Sasha Levin wrote: > It sounds like trinity is breaking (well printing a message, not really > breaking) on any addition. So if we follow that the perf sysfs interface > would be completely frozen and can never be extended over today. Trinity is breaking on any *ABI-breaking* additions. You can add arbitrary fields to sysfs events/* as long as there's a corresponding format/* entry. > I don't think it's a big problem that a test tool needs to be extended > when the software it's testing changes. Trinity isn't the only tool that would break, I just picked it as an example because it's one that kernel devs have likely heard of. Vince -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/