Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753605Ab3GXTFl (ORCPT ); Wed, 24 Jul 2013 15:05:41 -0400 Received: from one.firstfloor.org ([193.170.194.197]:55963 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752153Ab3GXTFj (ORCPT ); Wed, 24 Jul 2013 15:05:39 -0400 Date: Wed, 24 Jul 2013 21:05:37 +0200 From: Andi Kleen To: Vince Weaver Cc: Andi Kleen , Andi Kleen , acme@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Stephane Eranian , torvalds@linux-foundation.org, trinity@vger.kernel.org Subject: Re: [PATCH 1/2] tools, perf: Add a precise event qualifier v2 Message-ID: <20130724190537.GW6123@two.firstfloor.org> References: <1374501138-13496-1-git-send-email-andi@firstfloor.org> <20130723060108.GA18396@tassilo.jf.intel.com> <20130723225150.GT6123@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 27 > I'd prefer if it were > > precise_ip:0-1 > > as the code you use to set the value looks like > attr->precise_ip=2; > I don't think you can even set bits 15-16 of flags directly, can you? Sorry I meant flags as an alias of "the 64bits currently occupied by the bitfield". Perhaps the name choice was not very good. "flags_bitfield" ? So the tool would only need to know that, not every bit. In theory it could be also generalized as a byte offset to perf_event, but that may be overengineered. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/