Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752852Ab3GXW0m (ORCPT ); Wed, 24 Jul 2013 18:26:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55742 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951Ab3GXW0l (ORCPT ); Wed, 24 Jul 2013 18:26:41 -0400 Date: Wed, 24 Jul 2013 15:26:40 -0700 From: Greg Kroah-Hartman To: H Hartley Sweeten Cc: "linux-kernel@vger.kernel.org" , Ian Abbott Subject: Re: [PATCH 22/36] staging: comedi: convert class code to use dev_groups Message-ID: <20130724222640.GA22336@kroah.com> References: <1374703539-9705-1-git-send-email-gregkh@linuxfoundation.org> <1374703539-9705-23-git-send-email-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1107 Lines: 28 On Wed, Jul 24, 2013 at 05:11:25PM -0500, H Hartley Sweeten wrote: > On Wednesday, July 24, 2013 3:05 PM, Greg Kroah-Hartman wrote: > > > > The dev_attrs field of struct class is going away soon, dev_groups > > should be used instead. This converts the comedi class code to use the > > correct field. > > > > Cc: Ian Abbott > > Cc: H Hartley Sweeten > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/staging/comedi/comedi_fops.c | 39 ++++++++++++++++++------------------ > > 1 file changed, 20 insertions(+), 19 deletions(-) > > Looks good to me. Not sure what my sign off should be so take your pick. > > Reviewed-by: H Hartley Sweeten > > Acked-by: H Hartley Sweeten Thanks, I'll take both :) greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/