Message-ID: <1374705685.29835.15.camel@x61.thuisdomein>
Subject: Re: [PATCH 4/5] SLIP: Add error message for xleft non-zero
From: Paul Bolle <pebolle@tiscali.nl>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dean Jenkins <Dean_Jenkins@mentor.com>, Andre Naujoks <nautsch2@gmail.com>,
        linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>
Date: Thu, 25 Jul 2013 00:41:25 +0200
In-Reply-To: <20130724221849.GD21709@kroah.com>
References: <1372779094-11730-1-git-send-email-Dean_Jenkins@mentor.com>
	 <1372779094-11730-5-git-send-email-Dean_Jenkins@mentor.com>
	 <20130724221849.GD21709@kroah.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1405
Lines: 42

On Wed, 2013-07-24 at 15:18 -0700, Greg Kroah-Hartman wrote:
> On Tue, Jul 02, 2013 at 04:31:33PM +0100, Dean Jenkins wrote:
> > Add a printk to show when xleft is non-zero in sl_encaps.
> > 
> > The idea is to see whether a previous SLIP frame failed to be
> > fully transmitted.
> > 
> > Signed-off-by: Dean Jenkins <Dean_Jenkins@mentor.com>
> > ---
> >  drivers/net/slip/slip.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c
> > index f7303e0..e2eff84 100644
> > --- a/drivers/net/slip/slip.c
> > +++ b/drivers/net/slip/slip.c
> > @@ -395,6 +395,10 @@ static void sl_encaps(struct slip *sl, unsigned char *icp, int len)
> >  #endif
> >  		count = slip_esc(p, sl->xbuff, len);
> >  
> > +	if (sl->xleft)
> > +		printk(KERN_ERR "%s: ERROR: xleft is non-zero %d\n",
> > +		       __func__, sl->xleft);
> 
> dev_err() perhaps?

After looking at the commit explanation and the patch itself I wonder
why this should be printed at error level. Especially since patch 3/5
will set sl->xleft to zero immediately after.

So, dev_dbg() perhaps?

And can't this be merged into 3/5?


Paul Bolle  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/